Skip to content

Conversation

cweitkamp
Copy link
Contributor

  • Added support for groups of blinds

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp added the enhancement An enhancement or new feature for an existing add-on label Oct 21, 2025
@jlaur jlaur changed the title [avmfritz] Added support for groups of blinds [avmfritz] Add support for groups of blinds Oct 21, 2025
@lsiepel lsiepel requested a review from Copilot October 21, 2025 10:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for groups of blinds in the avmfritz binding, enabling control of roller shutters/blinds that are grouped together in the FRITZ!Box system.

Key Changes:

  • Added new FRITZ_GROUP_BLINDS thing type for blind groups
  • Moved LevelControlModel from DeviceModel to AVMFritzBaseModel to enable sharing between devices and groups
  • Updated handler logic to support blind control for both individual devices and groups

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
AVMFritzBindingConstants.java Added constant and ThingTypeUID for the new blinds group type
AVMFritzBaseModel.java Moved levelControlModel field and its getters/setters from DeviceModel to base class
DeviceModel.java Removed levelControlModel field as it was moved to parent class
AVMFritzBaseBridgeHandler.java Added logic to identify blind groups when discovering devices
AVMFritzBaseThingHandler.java Updated handler to process blind updates for both devices and groups
thing-types.xml Added XML configuration for the new blinds group thing type
avmfritz.properties Added i18n labels for blinds group
README.md Updated documentation to describe the new blinds group support
AVMFritzDeviceListModelTest.java Added test data and validation test for blinds group
AVMFritzDiscoveryServiceOSGiTest.java Updated test to reflect new supported thing type count

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, except for the test failing and the typo discovered by copilot i have no additional comments.

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@lsiepel lsiepel merged commit 62a0a05 into openhab:main Oct 21, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.1 milestone Oct 21, 2025
@cweitkamp cweitkamp deleted the feature-avmfritz-blind-group branch October 21, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants