Skip to content

[siemenshvac] Fix sanetization of channel type UID #19512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2025
Merged

[siemenshvac] Fix sanetization of channel type UID #19512

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
325fb5d
adding call to sanetizeid into normalizedescriptor to be sure that ch…
lo92fr Oct 20, 2025
3804b48
move back method to private
lo92fr Oct 20, 2025
1b93bbe
simplify code
lo92fr Oct 20, 2025
cdf223a
fix bad changes
lo92fr Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ing.siemenshvac/src/main/java/org/openhab/binding/siemenshvac/internal/type/UidUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ private static String normalizeDescriptor(String descriptor) {
result = result.replace("-setpointhc", "-setpoint-hc");
result = result.replace("setphc", "-setpoint-hc");

return result;
return sanetizeId(result);
}

/**
Expand All @@ -142,18 +142,18 @@ private static String normalizeDescriptor(String descriptor) {
public static ChannelTypeUID generateChannelTypeUID(SiemensHvacMetadataDataPoint dpt) throws SiemensHvacException {
String type = dpt.getDptType();
String shortDesc = dpt.getShortDescEn();
String result = normalizeDescriptor(shortDesc);
String channelTypeId = normalizeDescriptor(shortDesc);

try {
TypeConverter tp = ConverterFactory.getConverter(type);
if (!tp.hasVariant()) {
result = tp.getChannelType(dpt);
channelTypeId = tp.getChannelType(dpt);
}
} catch (ConverterTypeException ex) {
throw new SiemensHvacException(String.format("Can't find converter for type: %s", type), ex);
}

return new ChannelTypeUID(SiemensHvacBindingConstants.BINDING_ID, result);
return new ChannelTypeUID(SiemensHvacBindingConstants.BINDING_ID, channelTypeId);
}

/**
Expand Down