[matter] Send a source with all commands to items #19480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Cutrer <cody@cutrer.us>
florian-h05
approved these changes
Oct 14, 2025
digitaldan
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
LGTM, i don't see a cleaner way either short of creating a send(Item item, Command command) in the BaseDevice class and then sending a message on the event bus (like we do in scripting/rules), but that also introduces quite a bit of code/complexity just to tag commands with source.
lsiepel
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not seeing a clear way to get any sort of identifier for what user/connection sent a message in MatterBridge.java, so this only emits the package name without any actor information.