Skip to content

Conversation

druciak
Copy link
Member

@druciak druciak commented Oct 12, 2025

This PR contains fixes for Satel discovery tests disabled in #19230.

Related to changes introduced in openhab/openhab-core#5032.

Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>
@druciak druciak added the test label Oct 12, 2025
@druciak druciak requested a review from jlaur October 12, 2025 11:28
@Nadahar
Copy link
Contributor

Nadahar commented Oct 12, 2025

@jlaur This looks like a good way to solve this to me. It's hard to see that anything "of value" is lost by this change.

Copy link
Contributor

@Nadahar Nadahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick resolving!
Also @Nadahar for the analysis!
LGTM

@lsiepel lsiepel merged commit f0973cc into openhab:main Oct 12, 2025
3 checks passed
@lsiepel lsiepel added this to the 5.1 milestone Oct 12, 2025
@druciak druciak deleted the satel-discovery-test-fix branch October 12, 2025 17:07
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants