[mqtt.awtrix3] Corrected DSL Code and better App examples #19460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrRSatzteil
changed the title
DrRSatzteil
force-pushed
the
awtrixreadme
branch
2 times, most recently
from
84f4bf7 to
274d08b
Compare
Signed-off-by: Thomas Lauterbach <2452988+DrRSatzteil@users.noreply.github.com>
DrRSatzteil
force-pushed
the
awtrixreadme
branch
from
274d08b to
58d00a7
Compare
|
This fix was made due to comments in https://community.openhab.org/t/awtrix-3-binding-formerly-awtrix-light/149739/177?u=drrsatzteil |
There was a problem hiding this comment.
Pull Request Overview
This PR corrects syntax errors in DSL code examples and updates app naming to use more realistic custom application examples instead of generic names that could be confused with native Awtrix clock apps.
- Fixed array syntax in DSL code from
[255,165,0]tonewArrayList(255,165,0) - Replaced generic app examples (clock, weather, calendar) with specific custom apps (washing machine, doorbell, media player)
- Updated all corresponding variable names, comments, and documentation to match the new app examples
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes two code errors in the example DSL code in the README and uses better example apps so that they cannot be confused with standard apps on the awtrix clock.