[neeo] Fix unregistering of all mDNS services #19458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nadahar ping.. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an mDNS-related issue by correcting the cleanup behavior in the MdnsBrainDiscovery class. The change ensures proper service listener cleanup when the discovery service is closed.
- Replaces
unregisterAllServices()with targeted removal of the specific service listener
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jlaur
pushed a commit
that referenced
this pull request
Oct 9, 2025
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
jlaur
added
the
backported
jlaur
pushed a commit
that referenced
this pull request
Oct 9, 2025
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
jlaur
added
the
backported4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19359
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch