[ondilo] Handle command REFRESH #19455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Weger <weger.michael@gmx.net>
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for the REFRESH command in the Ondilo binding by introducing caching for measures and recommendations. The implementation allows users to refresh channel values on demand using cached data.
Key changes:
- Added caching mechanism for measures and recommendations to support REFRESH command
- Updated display precision for numeric channels (ORP and pH trend channels changed from 1 decimal to 0 decimal places)
- Improved code structure by consolidating measure processing logic
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| thing-types.xml | Updated display patterns for ORP and trend channels to show whole numbers |
| OndiloHandler.java | Added caching fields and implemented REFRESH command handling logic |
| OndiloBridge.java | Refactored measure processing to use new consolidated method |
| README.md | Updated example configurations and corrected formatting issues |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
....openhab.binding.ondilo/src/main/java/org/openhab/binding/ondilo/internal/OndiloHandler.java
Show resolved
Hide resolved
....openhab.binding.ondilo/src/main/java/org/openhab/binding/ondilo/internal/OndiloHandler.java
Show resolved
Hide resolved
....openhab.binding.ondilo/src/main/java/org/openhab/binding/ondilo/internal/OndiloHandler.java
Outdated
Show resolved
Hide resolved
....openhab.binding.ondilo/src/main/java/org/openhab/binding/ondilo/internal/OndiloHandler.java
Outdated
Show resolved
Hide resolved
MikeTheTux
added
the
enhancement
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
lsiepel
approved these changes
Oct 9, 2025
|
please merge this one as well as #19268. here is a openHAB 5.0.2 version of the change, if someone wants to do additional testing: |
DrRSatzteil
pushed a commit
to DrRSatzteil/openhab-addons
that referenced
this pull request
Oct 11, 2025
* handle command REFRESH Signed-off-by: Michael Weger <weger.michael@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle command REFRESH
Description
Measures and Recommendations are now cached in order to implement REFRESH command
Smaller improvements in state description and README.