Skip to content

[airq] Add support for mold and virus index #19446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 12, 2025
Merged

[airq] Add support for mold and virus index #19446

merged 13 commits into from
Oct 12, 2025

Conversation

nixoso
Copy link
Contributor

@nixoso nixoso commented Oct 5, 2025 •
edited
Loading

The following improvements are available:

  • Mold-free index in percent; the lower the index, the higher the potential mold risk.
  • Virus-free index in percent; the lower the index, the higher the potential virus risk.

The implementation Closes #19444

nixoso added 4 commits October 5, 2025 22:42
@nixoso
Implemented collection of values for the virus and mold index (openha…
2708aa8 
…b#19444)

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Added new channel descriptions for mold and virus index (openhab#19444)
dd6b5c9 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Update documentation (openhab#19444)
f1a9a4b 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Spotless check (openhab#19444)
8361d99 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
Add translation for new properties (openhab#19444)
12a3087 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
fwolter
fwolter reviewed Oct 7, 2025
View reviewed changes
@nixoso
[review] Changing channel names for better understanding. (openhab#19444
80be499 
)

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
fwolter
fwolter requested changes Oct 8, 2025
View reviewed changes
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/i18n/airq.properties Outdated
channel-type.airq.humidity_abs.label = Absolute Humidity
channel-type.airq.humidity_abs_maxerr.label = Max. Error Abs. Humidity
channel-type.airq.humidity_maxerr.label = Max. Error Humidity
channel-type.airq.mold.label = Mold Index
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be adjusted, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, translation is updated.

nixoso added 2 commits October 10, 2025 16:05
@nixoso
[review] fix translation (openhab#19444)
6c1fad8 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[fix] File does not end with a newline. (openhab#19444)
9ed881e 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
lsiepel
lsiepel requested changes Oct 11, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some comments to look at.

bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
Comment on lines +76 to +77
<channel id="virus_free_maxerr" typeId="virus_free_maxerr"/>
<channel id="mold_free_maxerr" typeId="mold_free_maxerr"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are not added to the readme, not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until now, the MaxErr channels were not explicitly listed.
@fwolter, should I add them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not, PR welcome :) Right of the bat, I couldn't find any documentation what exactly the max error value means. I assume it is the tolerance to be expected under the current environmental conditions.

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Oct 11, 2025
@lsiepel lsiepel changed the title [airq] Air-Q - Support for the mold and virus index [airq] Add support for mold and virus index Oct 11, 2025
nixoso added 4 commits October 11, 2025 20:16
@nixoso
[review] revert DE translation (openhab#19444)
7c4f353 
- translation are created and maintained in crowdin

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[review] Compound adjective should be capitalized (openhab#19444)
e1f4724 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[review] Description added for Virus-&Mold-Free MaxErr channel (openh…
e8758a0 
…ab#19444)

Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
@nixoso
[review] Spelling corrected in the README (openhab#19444)
dfebdb7 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
lsiepel
lsiepel requested changes Oct 11, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, now only the i18n plugin needs to regenerate the properties file

@nixoso
[review] add translation for labels (openhab#19444)
df7bdfd 
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
lsiepel
lsiepel approved these changes Oct 12, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

fwolter
fwolter approved these changes Oct 12, 2025
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for your contribution and your review effort, LGTM!

@fwolter fwolter merged commit e585d8e into openhab:main Oct 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fwolter fwolter fwolter approved these changes

@lsiepel lsiepel lsiepel approved these changes

@aurelio1 aurelio1 Awaiting requested review from aurelio1 aurelio1 is a code owner

Assignees

No one assigned

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[airq] Air-Q - add mold and virus index channels

3 participants

@nixoso @fwolter @lsiepel