[jsscripting] Make event object conversion work independent of wrapper #19429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
added
the
enhancement
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/rules-and-return-codes/166438/60 |
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
force-pushed
the
jsscripting-eventconversion
branch
from
7dc9fa3 to
d2b9746
Compare
kaikreuzer
requested changes
Oct 5, 2025
| * Delegate allowing AOP-style interception of calls, either before Invocation, or upon a {@link ScriptException} being | ||
| * thrown. | ||
| * Delegate allowing AOP-style interception of calls, either before invocation, after invocation, upon a | ||
| * {@link ScriptException} being |
There was a problem hiding this comment.
Suggested change
| * {@link ScriptException} being | |
| * {@link ScriptException} being thrown, or on receiving the script code. |
Signed-off-by: Florian Hotze <dev@florianhotze.com>
|
@kaikreuzer I addressed your review 👍 |
kaikreuzer
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.