-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[hue] Work around for new (black) bridge v3 certificate bug #19401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@jpalo ping: could you please test this? |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/cant-connect-new-hue-bridge-pro-to-openhab/166243/13 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
The developer guideline is here.. https://developers.meethue.com/develop/application-design-guidance/using-https/ |
There is probably a missing intermediate certificate..
|
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/cant-connect-new-hue-bridge-pro-to-openhab/166243/21 |
This comment was marked as off-topic.
This comment was marked as off-topic.
I have written to Signify asking for either a) the intermediate cert, or b) to update their firmware. But in the meantime we can do nothing but wait.. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ue/src/main/java/org/openhab/binding/hue/internal/connection/HueTlsTrustManagerProvider.java
Outdated
Show resolved
Hide resolved
...ue/src/main/java/org/openhab/binding/hue/internal/connection/HueTlsTrustManagerProvider.java
Outdated
Show resolved
Hide resolved
...enhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/connection/Clip2Bridge.java
Outdated
Show resolved
Hide resolved
...enhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/connection/Clip2Bridge.java
Outdated
Show resolved
Hide resolved
...enhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/connection/Clip2Bridge.java
Outdated
Show resolved
Hide resolved
...enhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/connection/Clip2Bridge.java
Outdated
Show resolved
Hide resolved
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/cant-connect-new-hue-bridge-pro-to-openhab/166243/33 |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@kaikreuzer it looks like the CI build is once again not able to download the thing type xml schema.. |
The new Hue Bridge (black) version 3 uses a different certificate chain than the older version 1 and 2 bridges. The new chain has a three link chain, and unfortunately Signify does not (yet) supply the intermediate certificate.
This PR is a work around for the time being until Signify does (eventually) supply the missing intermediate certificate. On v3 bridges we currently use a TrustAllTrustManager for verifying the HTTPS connections.
Whenever the missing intermediate certificate is finally provided, we will need to make another PR to do the certificate validation properly.
Fixes #19337
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch