-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[linky] Fix new url schema for getMeasures() related to September Enedis changes to WebAPI #19289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- add segment to URL - use new userId in URL - fix entry point from v1 to v2 Signed-off-by: Laurent ARNAL <laurent@clae.net>
Signed-off-by: Laurent ARNAL <laurent@clae.net>
...penhab.binding.linky/src/main/java/org/openhab/binding/linky/internal/api/EnedisHttpApi.java
Outdated
Show resolved
Hide resolved
....linky/src/main/java/org/openhab/binding/linky/internal/handler/ThingLinkyRemoteHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Linky binding to accommodate changes made by Enedis to their Web API in September 2025. The main purpose is to fix the URL schema for the getMeasures()
method due to API version migration and URL format changes.
- Updates API URLs from v1 to v2 for the PRM (Point de Référence de Mesure) measurement endpoints
- Introduces the use of
idPersonne
instead of the previous user ID format - Adds segment parameter support to measurement API calls
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
ThingLinkyRemoteHandler.java | Adds segment field, updates user ID retrieval logic, and modifies measurement method calls to include segment parameter |
BridgeRemoteEnedisWebHandler.java | Updates API URLs from v1 to v2, adds segment parameter to URL templates, and implements idPersonne retrieval |
EnedisHttpApi.java | Modifies getMeasures method signature to include segment parameter and updates all measurement data retrieval methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...penhab.binding.linky/src/main/java/org/openhab/binding/linky/internal/api/EnedisHttpApi.java
Outdated
Show resolved
Hide resolved
- hard coded segment - code simplification on RemoteHandler. Signed-off-by: Laurent ARNAL <laurent@clae.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
It has to be backported to 5.0.x but not to 4.3.x because there were many changes in the binding in 5.0. I asusme a specific PR would be required for 4.3.x. @lo92fr do you agree ? |
…dis changes to WebAPI (#19289) * fix new url schema for getMeasures(): - add segment to URL - use new userId in URL - fix entry point from v1 to v2 Signed-off-by: Laurent ARNAL <laurent@clae.net>
Yes, I agree that it will need separate PR. |
Not sure where you refer to, but if that PR should also be backported, a conflict of this PR might already be fixed when they are both applied. |
I refer to your last message on this PR #19142 that I don't see before. |
Ah yes, if you create a PR for #19142 targeting 4.3 branch, it might be possible to backport this PR here by cherry-picking. |
- Remove jsoup dependency. - Fully backport initialize() methods to implements new login process. - Backport URL changes : - PR openhab#19289 (September change) : - move PRM_INFO_BASE_URL to v2. - add segment to measure URL. - add new idPersonne in place of internalId. - PR openhab#19144 (August change) : - move USER_INFO_CONTRACT_URL to v2. Signed-off-by: Laurent ARNAL <laurent@clae.net>
Hello @lolodomo, @clinique, @isiepel,
This is a new patch to Linky addons that is due to somes new changes on Enedis Web API that occurs a few days ago.
The measure entry point move from the v1 api to v2 api.
There is also a few changes in the URL format :
Laurent.