Skip to content

Conversation

renescherer
Copy link
Contributor

myenergi Binding

This binding supports a number of devices provided by the company myenergi. They include the Zappi car charger (EVSE), the Eddi solar diverter and the Harvi remote sensor for CT clamps.

[myenergi] Initial contribution to support Zappi, Eddi and Harvi devices

Description

Although this is the first official PR for this binding, it has been in the market place for a while for 3.x and 4.x openHAB systems and has been used, tested and extended by various contributors. This is the latest version which aligns with the standard naming conventions and works with openHAB 5.x.

Details about the binding can be found in the market place

Testing

Your pull request will automatically be built and available under the following folder:
https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/

Signed-off-by: Rene Scherer <rene@scherer-online.com>
@renescherer renescherer requested a review from a team as a code owner August 25, 2025 22:39
@renescherer renescherer added the new binding If someone has started to work on a binding. For a new binding PR. label Aug 25, 2025
@wborn wborn requested a review from Copilot August 26, 2025 06:27
Copilot

This comment was marked as resolved.

Signed-off-by: Rene Scherer <rene@scherer-online.com>
@lsiepel lsiepel changed the title [myenergi] initial release of myenergi binding for openHAB 5.x [myenergi] Initial contribution Aug 27, 2025
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this binding. I left quite some comments, don't let it demotivate you, in general it looks good, it just are many small things to look at. I do have one slightly bigger comment burried somewhere about the seperation of concern regarding the bridge and its responsibilities. Let me know if any of my comments are unclear, it took me some time to review ;-)
When these are addressed, i can look at the remaining files (handlers + apiclient)

@renescherer
Copy link
Contributor Author

Thanks very much @lsiepel for the detailed review. I've started work on the changes and hopefully will have a new version available sometime next week.

Signed-off-by: Rene Scherer <rene@scherer-online.com>
Signed-off-by: Rene Scherer <rene@scherer-online.com>
…tances.

Signed-off-by: Rene Scherer <rene@scherer-online.com>
Signed-off-by: Rene Scherer <rene@scherer-online.com>
@renescherer
Copy link
Contributor Author

@lsiepel I've addressed most of your suggestions above. There are few where I had some further questions and I haven't restructured the files yet, so that it's easier to trace through the initial comments.

@lsiepel
Copy link
Contributor

lsiepel commented Oct 3, 2025

Updated open comments and added a few.

…te channels

Signed-off-by: Rene Scherer <rene@scherer-online.com>
@renescherer renescherer requested a review from lsiepel October 8, 2025 21:56
Signed-off-by: Rene Scherer <rene@scherer-online.com>
Signed-off-by: Rene Scherer <rene@scherer-online.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new binding If someone has started to work on a binding. For a new binding PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants