Replace the deprecated new URL() constructor

[lsiepel]

The deprecated new URL(String) points to URI.create(s).toURL() It only behaves slightly different.
The URI parsing is strict RFC 3986-compliant where the old URL parsing is lenient and accepts unencoded strings.

Unfortunately i do not know if the bindings actually have the need voor encoding and if they need further adjustments. Atleast http binding does.

[andrewfg]

LGTM siemensrds

[jlaur]

Unfortunately i do not know if the bindings actually have the need voor encoding and if they need further adjustments. Atleast http binding does.

Cool that you're doing this for all bindings. 👍 Some time ago I went binding by binding and paused/stopped my mission when I got to the http binding, which was not a 15 minute job, at least for me. 😄

[marcelrv]

LGTM: for miio

[lsiepel]

Cool that you're doing this for all bindings. 👍 Some time ago I went binding by binding and paused/stopped my mission when I got to the http binding, which was not a 15 minute job, at least for me. 😄

Really cool.. until i discovered it wasn't a 15 minute job haha. I created a helper method to parse the string as URI.
Anyway, i like your advice. The http binding does some 'fuzzy' stuff with urlencode.

https://foöo.bar will be encoded to => https://xn--foo-tna.bar
As the ö (UTF8) is not allowed in URI hostnames, it needs to be encoded, but the URI method mentioned earlier does not do this for hosts, only for paths.
I would propose to no longer perform this escaping, and let the binding fail with a decent error message and let the user adapt the url themselves.

Another topic is if the helpermethod that is now inside the http binding should be extracted to core StringUtils so it will be available to all bindings. wdyt?

As i'm not german and my experience with umlauts are limited, maybe @holgerfriedrich can add something to the case?

[digitaldan]

LGTM for venstarthermostat and openhabcloud 👍

[lsiepel]

Maybe @J-N-K can give some advice as i think he wrote the tests at the time for http?

[goopilot]

LGTM for folderwatcher

[lsiepel]

I removed http from this PR and will create another PR to no longer have this on hold.