[flume] Adapt to new restrictions in Flume API #18696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsiepel
reviewed
May 18, 2025
...nding.flume/src/main/java/org/openhab/binding/flume/internal/actions/FlumeDeviceActions.java
Outdated
Show resolved
Hide resolved
...nding.flume/src/main/java/org/openhab/binding/flume/internal/handler/FlumeDeviceHandler.java
Show resolved
Hide resolved
Signed-off-by: Jeff James <jeff@james-online.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lsiepel
changed the title
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
…enhab#18696) Signed-off-by: Jeff James <jeff@james-online.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Aug 6, 2025
…enhab#18696) Signed-off-by: Jeff James <jeff@james-online.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies how historical data is queried from the Flume API. Flume made the following restrictions to the API:
The binding now submits multiple yearly queries to get the baseline only on the first start of the binding and stores the number using the StorageService. It will also update the baseline number at the beginning of every month. Subsequent queries are done from the start of month.
A few minor cosmetic changes as well.
This issue has been mentioned and the fix verified here: https://community.openhab.org/t/flume-water-monitoring/119526/13?u=jsjames