Skip to content

[pythonscripting] Fix python timedelta to java duration mapping #18671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2025
+2 −2
Merged

[pythonscripting] Fix python timedelta to java duration mapping #18671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3198a7a
fix python timedelta to java duration mapping
HolgerHees May 10, 2025
69ac69c
fix duration accuracy
HolgerHees May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.openhab.automation.pythonscripting/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
<configuration>
<connectionUrl>scm:git:https://github.com/openhab/openhab-python</connectionUrl>
<checkoutDirectory>${project.build.directory}/python</checkoutDirectory>
<scmVersion>v1.0.0-rc1</scmVersion>
<scmVersion>v1.0.0-rc2</scmVersion>
<scmVersionType>tag</scmVersionType>
</configuration>
</execution>
Expand Down
2 changes: 1 addition & 1 deletion ...ing/src/main/java/org/openhab/automation/pythonscripting/internal/PythonScriptEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public class PythonScriptEngine
.targetTypeMapping(Value.class, Duration.class,
// picking two members to check as Duration has many common function names
v -> v.hasMember("total_seconds") && v.hasMember("total_seconds"),
v -> Duration.ofNanos(v.invokeMember("total_seconds").asLong() * 10000000),
v -> Duration.ofNanos(Math.round(v.invokeMember("total_seconds").asDouble() * 1000000000)),
HostAccess.TargetMappingPrecedence.LOW)

// Translate python item to org.openhab.core.items.Item
Expand Down