[powermax] Correct Equipment tags #18666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
the
enhancement
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Bad idea as it will generate other questions and I will not be able to merge the fix for equipment tag :( |
I would be happy to answer them here. .. Or over there as you prefer. |
|
I would prefer to comment in the global PR as it is general remarks. |
|
Ok I will move the point/property tags back to the other PR. In about 2 hours.. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
changed the title
PS waiting for your inputs in #18585 .. :) |
lolodomo
added
regression
rprescott308y
pushed a commit
to rprescott308y/openhab-addons
that referenced
this pull request
May 18, 2025
* powermax update tags Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
* powermax update tags Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #18558 (comment)
Note I also took the liberty to apply the Point & Property tags from #18585
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch