Skip to content

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented May 4, 2025

Fixes the underlying issue of #18583.

The previously provided fix caused the event to be triggered before updating the time series. Additionally, although it fixed the event in the specific scenario where a Thing action would trigger successful spot price updates, it did not make sure to update the time series in this case.

Now, Thing actions will not cause any unplanned requests, unless they are made for a subscription without any listeners. Otherwise only already cached prices will be returned, and the already applied retry policy will make sure to request prices when appropriate, and notify all listeners on success.

@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. regression Regression that happened during the development of a release. Not shown on final release notes. work in progress A PR that is not yet ready to be merged labels May 4, 2025
@jlaur jlaur force-pushed the energidataservice-fix-day-ahead-available-event branch 4 times, most recently from cece0d7 to 61ee4d2 Compare May 11, 2025 18:59
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the energidataservice-fix-day-ahead-available-event branch 2 times, most recently from 17b7a53 to 7a8ea81 Compare May 11, 2025 19:04
@jlaur jlaur marked this pull request as ready for review May 11, 2025 19:10
@jlaur jlaur removed work in progress A PR that is not yet ready to be merged additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels May 11, 2025
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the energidataservice-fix-day-ahead-available-event branch from 7a8ea81 to 67759fc Compare May 11, 2025 20:03
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@lsiepel lsiepel merged commit 9339931 into openhab:main May 12, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone May 12, 2025
@jlaur jlaur deleted the energidataservice-fix-day-ahead-available-event branch May 12, 2025 20:02
jlaur added a commit to jlaur/openhab-addons that referenced this pull request Jun 30, 2025
* Extract logic for calculating retry policy

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
kaikreuzer pushed a commit that referenced this pull request Jul 1, 2025
* Extract logic for calculating retry policy

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the backported A PR that has been cherry-picked to a patch release branch label Jul 1, 2025
phenix1990 pushed a commit to phenix1990/openhab-addons that referenced this pull request Jul 31, 2025
* Extract logic for calculating retry policy

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported A PR that has been cherry-picked to a patch release branch bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants