Skip to content

[tado] Add semantic tags #18512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 13, 2025
Merged

[tado] Add semantic tags #18512

merged 10 commits into from
May 13, 2025

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Apr 10, 2025 •
edited
Loading

In this PR we set semantic tags on Things and Channels.

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

andrewfg added 2 commits April 10, 2025 13:54
@andrewfg
[tado Add tags
432de1f 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
tweak
9d0fea5 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg self-assigned this Apr 10, 2025
andrewfg added 2 commits April 10, 2025 15:27
@andrewfg
webservice
c7e0cd7 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
airflow
005f07e 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@lsiepel lsiepel added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Apr 10, 2025
@andrewfg
adopt reviewer suggestions
5aecc66 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg requested a review from jlaur April 10, 2025 21:59
@andrewfg andrewfg removed the awaiting other PR Depends on another PR label Apr 16, 2025
andrewfg added 3 commits April 24, 2025 15:44
@andrewfg
adopt reveiwer suggestion
a3486c5 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Merge branch 'openhab:main' into tado-tags
3df5d70
@andrewfg
takeover inputs from openhab#18585 and other learnings
2f817ae 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
Copy link
Contributor Author

@jlaur this is another PR which had got caught up in the review process of #18585 and #18664 .. so I have taken over the learnings and feedback from those PRs consolidated them in this one, and removed the contents of this from those. So I think this one is now more than ready to go.

jlaur
jlaur reviewed May 12, 2025
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions added, otherwise LGTM.

@andrewfg
adopt reviewer suggestion
afea2b9 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
jlaur
jlaur approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 50ce473 into openhab:main May 13, 2025
2 checks passed
@jlaur jlaur added this to the 5.0 milestone May 24, 2025
phenix1990 pushed a commit to phenix1990/openhab-addons that referenced this pull request Jul 31, 2025
@andrewfg @phenix1990
[tado] Add semantic tags (openhab#18512)
0c6abf0 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlaur jlaur jlaur approved these changes

Assignees

@andrewfg andrewfg

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewfg @jlaur @lsiepel