[huesync] Fix resolving language resource string for an Exception #18508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgfeller
force-pushed
the
5.x.x/huesync/issue-18376
branch
from
c032c8c to
4ecfc7b
Compare
[huesync] Exception message is not resolved using language resource strings openhab#18376 - openhab#18376
pgfeller
force-pushed
the
5.x.x/huesync/issue-18376
branch
from
4ecfc7b to
2fcd8b6
Compare
Basic manual test with openHAB 5.0.0 - Build openhab#4616 Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
pgfeller
changed the title
pgfeller
added
additional testing preferred
pgfeller
removed
the
additional testing preferred
|
@lsiepel - I tested the code change on a productive 4.3.x branch for several weeks (minor changes to this code, due to v21 syntax features). Works stable ➡️ ready for review. |
lsiepel
reviewed
May 23, 2025
...huesync/src/main/java/org/openhab/binding/huesync/internal/connection/HueSyncConnection.java
Show resolved
Hide resolved
lsiepel
requested changes
May 23, 2025
lsiepel
changed the title
|
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
|
Hi @lsiepel, as code freeze for OH 5 is approaching, it would be nice if this PR could be merged if you're happy with the changes. |
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
…enhab#18508) Basic manual test with openHAB 5.0.0 - Build openhab#4616 Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Aug 6, 2025
…enhab#18508) Basic manual test with openHAB 5.0.0 - Build openhab#4616 Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me> Signed-off-by: Paul Smedley <paul@smedley.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[huesync] Exception message is not resolved using language resource strings #18376
Bugfix for the issue
Various improvements in exception handling (communication). Tested with openHAB 4.3.4 in productive system. OH 5.x patch: only basic tests were performed using openHAB 5.0.0 Build #4616