[emotiva] Fix keep alive when adding devices manually #18469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espenaf
force-pushed
the
emotiva_discovery_port_closed
branch
2 times, most recently
from
5aaf5f6 to
38cb5d0
Compare
lsiepel
requested changes
Mar 30, 2025
...g.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaUdpReceivingService.java
Outdated
Show resolved
Hide resolved
...ing.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaUdpSendingService.java
Outdated
Show resolved
Hide resolved
...ing.emotiva/src/main/java/org/openhab/binding/emotiva/internal/protocol/EmotivaXmlUtils.java
Outdated
Show resolved
Hide resolved
...ing.emotiva/src/main/java/org/openhab/binding/emotiva/internal/protocol/EmotivaXmlUtils.java
Outdated
Show resolved
Hide resolved
...ing.emotiva/src/main/java/org/openhab/binding/emotiva/internal/protocol/EmotivaXmlUtils.java
Outdated
Show resolved
Hide resolved
espenaf
force-pushed
the
emotiva_discovery_port_closed
branch
2 times, most recently
from
ef10d79 to
0f8e868
Compare
* Improves handling of keep alive. * Bumps default protocol version 3.0. * Add documentation about opening of ports, protocol versions and keep alive. Signed-off-by: Espen Fossen <espenaf@junta.no>
espenaf
force-pushed
the
emotiva_discovery_port_closed
branch
from
0f8e868 to
d328134
Compare
Thanks. I see I got cought up in some NotNull/Nullable stuff again here, removed some of the checks that was redundant, and introducing the use of |
|
@lsiepel I have pushed fixes for all the comments, so please look at the changes when you have time. |
Signed-off-by: lsiepel <leosiepel@gmail.com>
lsiepel
changed the title
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
* [emotiva] Fix issue with keep alive when adding devices manually. * Improves handling of keep alive. * Bumps default protocol version 3.0. * Add documentation about opening of ports, protocol versions and keep alive. Signed-off-by: Espen Fossen <espenaf@junta.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18468.
Has been tested on 4.3.x and 5.0.0-SNAPSHOT. Backporting should be possible, and probably disariable to avoid this issue for users.