[tado] OAuth RFC-8628 authentication work flow

[andrewfg]

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Backport of: #18354

The Jar file for testing is here (but it requires the latest patch OH v4.3.4 or greater).

org.openhab.binding.tado-4.3.4-SNAPSHOT.zip

[lsiepel]

When i build this locally i get a spotless issue. I also wonder if the header changes are going to be an issue.

Edit: labels are not needed. Only to the original PR i will add a patch label once succesfully patched.

[andrewfg]

When i build this locally i get a spotless issue.

Is it due to the copyright years 2025 vs 2024? => Which is the correct year for back ported code?

[lsiepel]

When i build this locally i get a spotless issue.

Is it due to the copyright years 2025 vs 2024? => Which is the correct year for back ported code?

No pom.xml Don't think the headers are an issue. as when performaing a regular backport they are also not an issue.

[andrewfg]

Ok I did spotless on the pom (and changed the year anyway), so please try again.

[andrewfg]

maybe also an issue with the header comment notation /** vs. /* ??

[andrewfg]

@lsiepel the local build works now, so please try the CI build again..

EDIT: the CI build seems to be frozen Waiting for status to be reported .. and I don't know how to retrigger it.

[lsiepel]

Thanks, LGTM

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tado-authentication/163276/2

[andrewfg]

@lsiepel do you have any idea how to force the CI build? I have tried everything. Someone had suggested to close and then immediately reopen the PR, but I am slightly reluctant. WDYT?

[lsiepel]

@lsiepel do you have any idea how to force the CI build? I have tried everything. Someone had suggested to close and then immediately reopen the PR, but I am slightly reluctant. WDYT?

@holgerfriedrich or @wborn both checks seem to be hanging, any thoughts?

[holgerfriedrich]

@holgerfriedrich or @wborn both checks seem to be hanging, any thoughts?

I think it is not even started. Nothing listed in the Actions tab.
If I look at ci-build.yml, there seems not trigger for branches other than main.

openhab-addons/.github/workflows/ci-build.yml

Line 11 in 02b3daa

- 'main'

Anyway, IMHO the 4.3.x branch would not pass the tests - as long as we do not date headers back to 2024 and start all newly added files with a ** header instead of *.

[andrewfg]

as long as we do not date headers back to 2024 and start all newly added files with a ** header instead of *

I did all that. And it builds locally just fine. The "only" problem is that the CI build is not running, so we cannot "prove" that it builds on the cloud.

[holgerfriedrich]

Yes, you did for your PR. But all the other PRs cherry-picked to 4.3.x do not pass those checks.
We typically just cherry-pick and push, without applying modifications.
So at least the style checks etc. typically fail.

I just compared #18354 to this PR, and besides the README there are no differences besides this one:

[andrewfg]

besides the README there are no differences besides this one:

@holgerfriedrich I guess you figured it out already, but in case not, that change was due to a regression caused by the original PR, which therefore seemed sensible to also back port here.

[andrewfg]

We typically just cherry-pick and push, without applying modifications.

@holgerfriedrich / @lsiepel just for the avoidance of doubt, I am assuming that one or other of you will do this push. Or do you need anything more from me?

Also I wonder if you can inform me where the snapshots of such pushes are located? In order to pre-test and confirm everything before the formal v4.3.4 patch will be released. (I see v5.x snapshots only on JFrog but I assume that v4.3.x are still being built and stored somewhere else .. or??)

[andrewfg]

Just to confirm that Tado has definitely turned off their old authentication system, se we definitely need this backport asap.

[andrewfg]

Many thanks @lsiepel :)

[andrewfg]

#18481