[hue] Add semantic tags #18341
Merged
[hue] Add semantic tags #18341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
enhancement
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…dons into tag-test-hue
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
changed the title
andrewfg
changed the title
andrewfg
changed the title
andrewfg
changed the title
andrewfg
changed the title
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
|
@jlaur we don't yet have all the required equipment tags in OH core, but it would be good if you could look at this code anyway already. |
andrewfg
changed the title
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
changed the title
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
awaiting other PR
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
|
@jlaur perhaps you can kindly take a look at this one? It did get caught up in the #18585 auto-tagging process .. however it was never actually reviewed by anyone in that PR. Therefore I think that the changes I made manually via this PR are more likely to be correct than the auto-tagged version. (So I will also delete the auto-changes..). Note: I draw your attention to the code in the Thing handler where I am dynamically applying equipment tags at run-time to the Things depending on their actual reported capabilities. This can serve as a good code example for other bindings that need run-time tagging. |
jlaur
reviewed
May 12, 2025
...ab.binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/Clip2ThingHandler.java
Show resolved
Hide resolved
...ab.binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/Clip2ThingHandler.java
Show resolved
Hide resolved
bundles/org.openhab.binding.hue/src/main/resources/OH-INF/thing/Clip2Thing.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
|
@jlaur default tags removed |
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we set semantic tags on Things and Channels.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch