[dirigera] Initial contribution #17719

weymann · 2024-11-07T21:42:22Z

Binding for IKEA DIRIGERA hub for smart products.

~~The work ist still in progress but I would like to start the review to find breaking changes right now and not at the end, e.g. thing and channel names.~~

The binding is published on Marketplace and Community Discussion is active.

lsiepel

Only looked at the thing-structure.xml files as you wanted early feedback.

I did not repeat the same comments for multiple Things. As this seems a well strucutered binding, i think it would be easy for you to project my comments on the other Things.

Extra note, please user system state channels where possible:
https://www.openhab.org/docs/developer/bindings/thing-xml.html#system-state-channel-types

bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/air-purifier.xml

bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/blind.xml

bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/channel-types.xml

bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/sound-controller.xml

bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/speaker.xml

bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/thing/temperature-light.xml

weymann · 2024-11-13T14:28:08Z

@lsiepel
Thanks for the fast reply - I'll start now working on this.

weymann · 2024-12-01T22:50:28Z

@lsiepel
All channel adaptions done which shall be now in a stable status.
Binding is running for several community members who reported positive results for several devices. Stability improved with watchdog running.

I don't forsee changes in architecture, class structure and general behavior. Only in specific device handlers if bugfixes are necessary. So I would ask to extend the review on code. Leave logging out of scope, this is still messy and I'm still working on that.

...dirigera/src/main/java/org/openhab/binding/dirigera/internal/handler/scene/SceneHandler.java

weymann · 2024-12-11T19:54:40Z

@lsiepel @jlaur
What's wrong with the DateTimeType? Didn't changed anything but now it's throwing an error!

First log: String got from device json - ok
Second log: ZonedDateTime after conversion with defined TimeZone +02:00 - ok
Third log: Created DateTimeType

[main] WARN  o.o.b.d.i.handler.scene.SceneHandler - LastTrigger Instant       2024-10-16T00:21:15.977Z
[main] WARN  o.o.b.d.i.handler.scene.SceneHandler - LastTrigger ZonedDateTime 2024-10-16T02:21:15.977+02:00[Europe/Berlin]
[main] WARN  o.o.b.d.i.handler.scene.SceneHandler - LastTrigger DateTimeType  2024-10-16T00:21:15.977+0000
[main] WARN  o.o.b.d.internal.mock.CallbackMock - Update dirigera:scene:test-device:last-trigger : 2024-10-16T00:21:15.977+0000

Code here

...g.dirigera/src/test/java/org/openhab/binding/dirigera/internal/handler/scene/TestScenes.java

jlaur · 2024-12-11T20:12:53Z

What's wrong with the DateTimeType?

Hopefully nothing is wrong - see #17719 (comment)

Didn't changed anything but now it's throwing an error!

I assume it's your test throwing an error? Otherwise please be more specific. See #17719 (comment) regarding the test.

lsiepel

So many files to look at, so have to break this up into smaller review rounds. This is a first pass. Besides the comments, want to point to recent changes:
color-temperate channels: #17754 for recent DatetimeType channels: #17725

Edit: lol. nice timing

bundles/pom.xml

....openhab.binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/Constants.java

bundles/org.openhab.binding.dirigera/README.md

bundles/org.openhab.binding.dirigera/doc/follow-sun.png

bundles/org.openhab.binding.dirigera/README.md

...ing.dirigera/src/main/java/org/openhab/binding/dirigera/internal/DirigeraHandlerFactory.java

...rigera/src/main/java/org/openhab/binding/dirigera/internal/exception/NoGatewayException.java

weymann · 2024-12-11T22:05:46Z

So many files to look at, so have to break this up into smaller review rounds. This is a first pass. Besides the comments, want to point to recent changes: color-temperate channels: #17754 for recent DatetimeType channels: #17725

Edit: lol. nice timing

For color temperature #17754 since the beginning it was no option to set kelvin or system:color-temperature-abs directly - this should be fine!
For DateTimeType commit is already in place

bundles/org.openhab.binding.dirigera/pom.xml

weymann · 2025-02-26T20:34:07Z

FYI @lsiepel
Please check my review responses if they are ok or further discussion is needed

From community I don't get further problem reports and I don't intent to change this PR.

lsiepel

Thanks for looking at the comments and move this forward. Looked at 142/169 files. I think i need one more partial review to have everything covered. Overall the codes looks good, so i expect we can finish this soon.

bundles/org.openhab.binding.dirigera/doc/Info_Note_VOC_Index.pdf

bundles/org.openhab.binding.dirigera/README.md

.../src/main/java/org/openhab/binding/dirigera/internal/discovery/DirigeraDiscoveryManager.java

...src/main/java/org/openhab/binding/dirigera/internal/discovery/DirigeraDiscoveryRunnable.java

...igera/src/main/java/org/openhab/binding/dirigera/internal/handler/plug/PowerPlugHandler.java

bundles/org.openhab.binding.dirigera/src/test/resources/coverart/sonos-radio-cocktail-hour.avif

bundles/org.openhab.binding.dirigera/src/main/resources/OH-INF/addon/addon.xml

....binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/network/Websocket.java

jlaur · 2025-02-27T21:57:59Z

Spotless must be applied after #18318.

weymann · 2025-03-07T20:04:21Z

Any ideas why build doesn't work?
pom.xml failure but I

synced fork
updtaed main
rebased on main
spotless:apply
local build runs fine

lsiepel · 2025-03-07T20:31:26Z

Any ideas why build doesn't work? pom.xml failure but I

synced fork

updtaed main

rebased on main

spotless:apply

local build runs fine

It is spotless for sure. Some xml line breaks.

Are all changes (upstream merges) pulled into your local branch? As you say that builds fine.

weymann · 2025-03-07T20:49:50Z

Are all changes (upstream merges) pulled into your local branch? As you say that builds fine.

Yes, I'm sure

Command line build

Github rebased on latest PR merged 6 hours ago

weymann · 2025-04-19T15:59:12Z

@weymann are you able to proceed and resolve the comments?

Just pushed the solved review comments so far.
Comments from Andrew not in yet

On debug actions I would really like to have an opionion from e.g. core maintainers.

dumping JSON snapshot helps
- to identify device ids for textual configuration
- check for 3rd party devices attached to DIRIGERA hub
custonDebug helps to debug specific devices
- helped for community post here
- will help for community here
getToken helps to try out commands e.g. with postman

lsiepel · 2025-04-26T12:58:52Z

Added an example for the CLI command and pinged another maintainer to look at the debug logging. There are also a few burried comments left.

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

...c/main/java/org/openhab/binding/dirigera/internal/handler/light/TemperatureLightHandler.java

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

andrewfg

LGTM

lsiepel · 2025-05-16T11:38:47Z

It is ready to merge when there is agreement / follow-up on two comments, i really appreciate it when another @openhab/add-ons-maintainers can comment:
#17719 (comment)
#17719 (comment)

lsiepel · 2025-06-08T08:53:51Z

@lolodomo @jlaur any of you available to look at the two remaining comments about debugging?

lolodomo · 2025-06-08T09:27:18Z

I tried to answer to the two comments.

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

weymann · 2025-06-11T21:29:28Z

Comments from @lolodomo corrected.

lsiepel

Thanks, LGTM

Do you need additional testing time or community members to verify the latest changes are all good?

jaywiseman1971 · 2025-06-12T11:23:21Z

Is there a 4.3.x version to test, I'd be glad to.

Best, Jay

weymann · 2025-06-12T14:56:35Z

@lsiepel
Last 2 commits are only handling the thing action / console changes. The rest I would say is well aged.

@jaywiseman1971
You can install it from Marketplace. Discussion here.

lsiepel · 2025-06-12T17:22:16Z

Thanks again! Now, you could add the binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website

* feature-squash Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

* feature-squash Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

weymann requested a review from a team as a code owner November 7, 2024 21:42

lsiepel added the new binding If someone has started to work on a binding. For a new binding PR. label Nov 8, 2024

lsiepel requested changes Nov 8, 2024

View reviewed changes

weymann force-pushed the dirigera branch from 385fc1a to 579ee3c Compare November 18, 2024 09:49

weymann requested a review from lsiepel December 1, 2024 22:37

jlaur reviewed Dec 11, 2024

View reviewed changes

...dirigera/src/main/java/org/openhab/binding/dirigera/internal/handler/scene/SceneHandler.java Show resolved Hide resolved

jlaur reviewed Dec 11, 2024

View reviewed changes

...g.dirigera/src/test/java/org/openhab/binding/dirigera/internal/handler/scene/TestScenes.java Outdated Show resolved Hide resolved

lsiepel requested changes Dec 11, 2024

View reviewed changes

weymann force-pushed the dirigera branch from 9bca9fb to e5c865a Compare December 11, 2024 22:41

weymann changed the title ~~[WIP] [dirigera] Initial contribution~~ [dirigera] Initial contribution Dec 13, 2024

weymann requested a review from lsiepel December 14, 2024 16:48

wborn reviewed Dec 15, 2024

View reviewed changes

bundles/org.openhab.binding.dirigera/pom.xml Outdated Show resolved Hide resolved

weymann force-pushed the dirigera branch from 10e7b4f to 0a88697 Compare December 17, 2024 15:15

weymann requested a review from jsetton as a code owner January 14, 2025 22:10

weymann force-pushed the dirigera branch from 6e86342 to 9462aa7 Compare January 14, 2025 23:21

lsiepel requested changes Feb 26, 2025

View reviewed changes

weymann force-pushed the dirigera branch 2 times, most recently from 15a8685 to e4b7680 Compare March 7, 2025 19:59

weymann requested a review from florian-h05 as a code owner March 8, 2025 16:44

lsiepel removed the request for review from jsetton March 8, 2025 20:07

weymann added 3 commits May 2, 2025 01:10

temperature-abs

1b87fde

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

temperature-abs

b26f635

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

OH5 adaptions

3ecc36b

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

andrewfg reviewed May 2, 2025

View reviewed changes

...c/main/java/org/openhab/binding/dirigera/internal/handler/light/TemperatureLightHandler.java Show resolved Hide resolved

weymann added 6 commits May 4, 2025 00:56

initialize rework

6112a20

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

checkstyle

cf4156a

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

plug detection improvement

1ab1bb6

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

remove unused model function

f631e94

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

go back to rgb color model

560f8af

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

OH5 header adaptions

2fe6c44

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

andrewfg approved these changes May 16, 2025

View reviewed changes

weymann added 2 commits June 11, 2025 22:59

move debug actions to console

22bf1da

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

OH5 adaptions

229d019

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

weymann requested review from lolodomo and lsiepel June 11, 2025 21:29

lsiepel approved these changes Jun 12, 2025

View reviewed changes

lsiepel merged commit 78c4962 into openhab:main Jun 12, 2025
2 checks passed

lsiepel added this to the 5.0 milestone Jun 12, 2025

weymann mentioned this pull request Jun 12, 2025

[dirigera] addon logo openhab/openhab-docs#2507

Merged

phenix1990 pushed a commit to phenix1990/openhab-addons that referenced this pull request Jul 31, 2025

[dirigera] Initial contribution (openhab#17719)

351aa18

* feature-squash Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Aug 6, 2025

[dirigera] Initial contribution (openhab#17719)

6edefa0

* feature-squash Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Uh oh!

[dirigera] Initial contribution #17719

[dirigera] Initial contribution #17719

Uh oh!

Conversation

weymann commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lsiepel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weymann commented Nov 13, 2024

Uh oh!

weymann commented Dec 1, 2024

Uh oh!

Uh oh!

weymann commented Dec 11, 2024

Uh oh!

Uh oh!

jlaur commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lsiepel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weymann commented Dec 11, 2024

Uh oh!

Uh oh!

weymann commented Feb 26, 2025

Uh oh!

lsiepel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlaur commented Feb 27, 2025

Uh oh!

weymann commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lsiepel commented Mar 7, 2025

Uh oh!

weymann commented Mar 7, 2025

Uh oh!

weymann commented Apr 19, 2025

Uh oh!

lsiepel commented Apr 26, 2025

Uh oh!

Uh oh!

andrewfg left a comment

Choose a reason for hiding this comment

weymann commented Nov 7, 2024 •

edited

Loading

jlaur commented Dec 11, 2024 •

edited

Loading

lsiepel left a comment •

edited

Loading

weymann commented Mar 7, 2025 •

edited

Loading