[onecta] Initial contribution #16730

adr001db · 2024-05-09T09:47:22Z

New Binding for Daikin using Onecta.

With the newer Daikin units it is no longer possible to control them directly (as is done in the other Daikin binding). The units can only be connected to the Daikin cloud called Onecta.
The units can then ‘only’ be controlled with the Onecta app on a phone or tablet.
This binding makes it possible to still control the units with OpenHAB. It’s now done by connecting the binding to Daikin’s Onecta.
The unit information is then received from the Daikin cloud just like the app. Commands to the units also run via the Daikin Cloud.
Older units can also be controlled with this binding as long as they are registered in Onecta.

Description

Please give a few sentences describing the overall goals of the pull request.
Give enough details to make the improvement and changes of the PR understandable
to both developers and tech-savy users.

Please keep the following in mind:

What is the classification of the PR, e.g. Bugfix, Improvement, Novel Addition, ... ?
New Binding
Did you describe the PRs motivation and goal?
I like to have the new binding official added to the openhab lib.
Did you provide a link to any prior discussion, e.g. an issue or community forum thread?
https://community.openhab.org/t/daikin-onecta-cloud-binding-4-0-0-0-5-0-0-0
Did you describe new features for the end user?
Did you describe any noteworthy changes in usage for the end user?
Was the documentation updated accordingly, e.g. the add-on README?
Does your contribution follow the coding guidelines:
https://www.openhab.org/docs/developer/guidelines.html
I hope so. this is my first contribution and everything is new.
Did you check for any (relevant) issues from the static code analysis:
https://www.openhab.org/docs/developer/bindings/#include-the-binding-in-the-build
Did you sign-off your work:
https://www.openhab.org/docs/developer/contributing.html#sign-your-work
At first this went wrong so I created a new Fork and copied my code to this. So the first commit is a large one.

Testing

Your pull request will automatically be built and available under the following folder:
https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/

The Jar can be found at:
https://community.openhab.org/t/daikin-onecta-cloud-binding-4-0-0-0-5-0-0-0

Don't forget to submit a thread about your Add-on in the openHAB community:
https://community.openhab.org/c/add-ons
-->

lsiepel · 2024-05-09T11:13:14Z

Thanks for your contribution. As there are many PR's currently being reviewed, it might take some time, evantually it will be picked up by one of the maintainers.

Can you remove the ecobee files? Add yourself to the codewoner file and perform some kind of self-review with this checklist in mind it will speed up the review process if easy spotted issues can be fixed upfront.

Edit: Also the build fails and you might want to check SAT warnings.

lsiepel

Some initial comments after half way review. Ping me when you are ready for resuming

bundles/org.openhab.binding.onecta/onecta.items

bundles/org.openhab.binding.onecta/ToDo.txt

bundles/org.openhab.binding.onecta/pom.xml

...ing.onecta/src/main/java/org/openhab/binding/onecta/internal/api/OnectaConnectionClient.java

...necta/src/main/java/org/openhab/binding/onecta/internal/api/dto/units/FanOperationModes.java

...g.onecta/src/main/java/org/openhab/binding/onecta/internal/api/dto/units/OperationModes.java

...onecta/src/main/java/org/openhab/binding/onecta/internal/api/dto/units/SensoryDataValue.java

adr001db · 2024-05-10T09:38:59Z

Hi @lsiepel,
Thanks for the first comments on my pullrequest.

But can you please help me. I'am struggeling with the First commit. This commit is not mine. I tried to delete it, but I don't think it went well.

What should I do with this ?

Greetings Alexander

lsiepel · 2024-05-10T10:16:32Z

If you refer to DCO, some guidance is here:
https://github.com/openhab/openhab-addons/pull/16730/checks?check_run_id=24814490170

The builds fail to spotless:
https://github.com/openhab/openhab-addons/actions/runs/9030368073/job/24814490996?pr=16730

That commit that you refer to does not seem to be a problem.

adr001db · 2024-05-10T10:28:02Z

Thanks than i will ignore it.

Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

bundles/org.openhab.binding.onecta/README.md

lsiepel · 2025-07-27T11:40:54Z

Thanks for continuing on this. The PR is getting in a good shape. I think I have todo a final review round when I’m back in about two weeks.

adr001db · 2025-07-27T11:52:38Z

Thanks, I'm very happy that things are going well. Have a nice holiday. At least, that's what I assume you'll be doing. :o)

Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

jlaur · 2025-08-23T11:55:40Z

Please add yourself to the CODEOWNERS file.

- Add project to CODEOWNERS Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

adr001db · 2025-10-11T13:51:14Z

@lsiepel hello, Did you have a chance to look at the pullrequest ?

lsiepel · 2025-10-11T18:23:12Z

I made a start, and paused. I have too many other PR's at the moment to look at. I can handle multiple smaller, but not a large one like this at the moment. It might take some time, so don't wait for me.

adr001db · 2025-10-13T15:43:51Z

@Isiepel

I don't quite understand what you mean. "So don't wait for me."
I'am trying to get a final approvment, but i also do'nt know how the proces for this works and who can give a final approval.

lsiepel · 2025-10-20T12:56:43Z

a start, and paused. I have too many other PR's at the moment to look at. I can handle multiple smaller, but not a large one like this at the moment. It might take some time, so don't wait for me.

Your PR needs to be reviewed by a maintainer. Usually the maintainer that starts the review proces also finishes it to the end. As this is a larger PR, and i have enough on my plate now, i only did a quick check. So another maintainer may or may not proceed with revieweing this PR. Just give it time, it will be reviewed eventually. It just might take some time.
Obviously you can self-review and fix issues or improve parts that you learned from other reviews.

lsiepel · 2025-10-23T08:14:46Z

Sorry, i mixed up two PR's anyway. I have some time to look at it. i'll start with a co-pilot review.

Copilot

Pull Request Overview

Copilot reviewed 116 out of 130 changed files in this pull request and generated 6 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...g.onecta/src/main/java/org/openhab/binding/onecta/internal/service/ChannelsRefreshDelay.java

...enhab.binding.onecta/src/main/java/org/openhab/binding/onecta/internal/type/TypeHandler.java

bundles/org.openhab.binding.onecta/src/main/resources/OH-INF/thing/onecta-climatecontrol.xml

Copilot · 2025-10-23T08:16:49Z

bundles/org.openhab.binding.onecta/src/main/resources/OH-INF/thing/onecta-climatecontrol.xml

+		<config-description>
+			<parameter name="unitID" type="text" required="true">
+				<label>Unit ID</label>
+				<description>Diakin unit</description>


Corrected spelling of 'Diakin' to 'Daikin'.

bundles/org.openhab.binding.onecta/src/main/resources/OH-INF/thing/onecta-account.xml

Copilot · 2025-10-23T08:16:50Z

bundles/org.openhab.binding.onecta/src/main/resources/OH-INF/thing/onecta-climatecontrol.xml

+	<channel-type id="acunit-energy-heating-current-year-1" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year January</label>
+		<description>The energy usage for heating this year January</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-2" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year February</label>
+		<description>The energy usage for heating this year February</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-3" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year March</label>
+		<description>The energy usage for heating this year March</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-4" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year April</label>
+		<description>The energy usage for heating this year April</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-5" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year May</label>
+		<description>The energy usage for heating this year May</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-6" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year June</label>
+		<description>The energy usage for heating this year June</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-7" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year July</label>
+		<description>The energy usage for heating this year July</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-8" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year August</label>
+		<description>The energy usage for heating this year August</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-9" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year September</label>
+		<description>The energy usage for heating this year September</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-10" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year October</label>
+		<description>The energy usage for heating this year October</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-11" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year November</label>
+		<description>The energy usage for heating this year November</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-12" advanced="true">
+		<item-type>Number:Energy</item-type>
+		<label>Energy Heating Current Year December</label>
+		<description>The energy usage for heating this year December</description>
+		<category>Energy</category>
+		<state readOnly="true" pattern="%.1f %unit%"/>
+	</channel-type>
+	<channel-type id="acunit-energy-heating-current-year-1" advanced="true">
+		<item-type>Number:Energy</item-type>


Duplicate channel-type definition: acunit-energy-heating-current-year-1 through acunit-energy-heating-current-year-12 are defined twice (lines 717-800 and 801-883), creating redundant and potentially conflicting definitions. Remove the duplicate definitions.

Suggested change

<channel-type id="acunit-energy-heating-current-year-1" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year January</label>

<description>The energy usage for heating this year January</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-2" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year February</label>

<description>The energy usage for heating this year February</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-3" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year March</label>

<description>The energy usage for heating this year March</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-4" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year April</label>

<description>The energy usage for heating this year April</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-5" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year May</label>

<description>The energy usage for heating this year May</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-6" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year June</label>

<description>The energy usage for heating this year June</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-7" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year July</label>

<description>The energy usage for heating this year July</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-8" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year August</label>

<description>The energy usage for heating this year August</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-9" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year September</label>

<description>The energy usage for heating this year September</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-10" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year October</label>

<description>The energy usage for heating this year October</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-11" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year November</label>

<description>The energy usage for heating this year November</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-12" advanced="true">

<item-type>Number:Energy</item-type>

<label>Energy Heating Current Year December</label>

<description>The energy usage for heating this year December</description>

<category>Energy</category>

<state readOnly="true" pattern="%.1f %unit%"/>

</channel-type>

<channel-type id="acunit-energy-heating-current-year-1" advanced="true">

<item-type>Number:Energy</item-type>

<channel-type id="acunit-energy-heating-current-year-1" advanced="true">

<item-type>Number:Energy</item-type>

lsiepel

Looked at 108/130 files. The core parts are left e.g. handlers, oauth, connection. Bu all documentation, dto's xml and other metadata files have been reviewed.
For the xml files i left some generic comments that need to be applied to all channel typoes and or things. Sorry, but that can be time consuming.

bundles/org.openhab.binding.onecta/README.md

lsiepel · 2025-10-23T08:17:42Z

bundles/org.openhab.binding.onecta/README.md

+It is **not** allowed to use localhost (Onecta will not accept this)
+- https://localhost:8443


Suggested change

It is **not** allowed to use localhost (Onecta will not accept this)

- https://localhost:8443

**note:*** It is **not** allowed to use `localhost` (Onecta will not accept this)

lsiepel · 2025-10-23T08:17:55Z

bundles/org.openhab.binding.onecta/README.md

+|------------------|---------|----------------------------------------------------------------|---------|----------|----------|
+| `refreshInterval`  | integer | Interval the device is polled in sec.                          | 600     | yes      | no       |
+
+


Suggested change

lsiepel · 2025-10-23T08:18:09Z

bundles/org.openhab.binding.onecta/README.md

+| Name             | Type    | Description                                                    | Default | Required | Advanced |
+|------------------|---------|----------------------------------------------------------------|---------|----------|----------|
+| `refreshInterval`  | integer | Interval the device is polled in sec.                          | 600     | yes      | no       |


nitpick: please align the table

lsiepel · 2025-10-23T08:18:41Z

bundles/org.openhab.binding.onecta/README.md

+| `refreshDelay`  | integer | Refresh Delay in sec. <br>Only available for thing 'device' and 'domestic-hot-water-tank'                | 15      | yes      | no       |
+
+### Explanation Refresh Delay:
+If a command is sent from the binding to OnectaCloud, it needs time to be processed by Daikin. 


Suggested change

If a command is sent from the binding to OnectaCloud, it needs time to be processed by Daikin.

If a command is sent from the binding to OnectaCloud, it needs time to be processed by Daikin.

bundles/org.openhab.binding.onecta/src/main/resources/OH-INF/thing/onecta-gateway.xml

bundles/org.openhab.binding.onecta/src/main/resources/OH-INF/thing/onecta-indoorunit.xml

bundles/org.openhab.binding.onecta/src/main/resources/OH-INF/thing/onecta-watertank.xml

adr001db requested a review from a team as a code owner May 9, 2024 09:47

adr001db force-pushed the onecta branch from bf11054 to 7561f45 Compare May 9, 2024 10:42

adr001db requested a review from mhilbush as a code owner May 9, 2024 10:42

lsiepel added the new binding If someone has started to work on a binding. For a new binding PR. label May 9, 2024

lsiepel changed the title ~~Onecta~~ [onecta] Initial contribution May 9, 2024

lsiepel requested changes May 10, 2024

View reviewed changes

lsiepel removed the request for review from mhilbush May 10, 2024 10:13

adr001db force-pushed the onecta branch from 8388534 to 1c1dd8c Compare May 12, 2024 12:44

adr001db requested review from GiviMAD, Hilbrand, andrewfg, ccutrer, clinique, cweitkamp, digitaldan, ecdye, hmerk, jannegpriv, kaikreuzer, lolodomo, lujop, markus7017, mherwege, paulianttila, ssalonen and vctender as code owners May 12, 2024 12:44

This comment was marked as resolved.

Sign in to view

adr001db added 3 commits July 27, 2025 11:57

[ONECTA] Pullrequest findings

e395fa4

Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

[ONECTA] Pullrequest findings

e22318f

Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

[ONECTA] Pullrequest findings

8346fc6

Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

lsiepel reviewed Jul 27, 2025

View reviewed changes

bundles/org.openhab.binding.onecta/README.md Outdated Show resolved Hide resolved

lsiepel reviewed Jul 27, 2025

View reviewed changes

bundles/org.openhab.binding.onecta/README.md Outdated Show resolved Hide resolved

[ONECTA] Pullrequest findings

b89c61b

Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

lsiepel requested review from Copilot and removed request for blafois, jlaur and wborn August 23, 2025 08:37

This comment was marked as outdated.

Sign in to view

adr001db added 2 commits August 23, 2025 15:02

[ONECTA] Pullrequest findings and documentation improvement

acb5955

- Add project to CODEOWNERS Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

[ONECTA] Documentation improvement

67dd1d4

Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

lsiepel requested a review from Copilot August 23, 2025 16:21

This comment was marked as outdated.

Sign in to view

Copilot AI reviewed Aug 23, 2025

View reviewed changes

adr001db and others added 2 commits October 7, 2025 12:36

Merge branch 'openhab:main' into onecta

0b83ced

[ONECTA] Fix FanControl on watertank

4062aae

Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>

lsiepel requested a review from Copilot October 23, 2025 08:14

Copilot AI reviewed Oct 23, 2025

View reviewed changes

lsiepel requested changes Oct 23, 2025

View reviewed changes

		It is not allowed to use localhost (Onecta will not accept this)
		- https://localhost:8443

	It is not allowed to use localhost (Onecta will not accept this)
	- https://localhost:8443
	note:* It is not allowed to use `localhost` (Onecta will not accept this)

		\|------------------\|---------\|----------------------------------------------------------------\|---------\|----------\|----------\|
		\| `refreshInterval` \| integer \| Interval the device is polled in sec. \| 600 \| yes \| no \|

	If a command is sent from the binding to OnectaCloud, it needs time to be processed by Daikin.

	If a command is sent from the binding to OnectaCloud, it needs time to be processed by Daikin.

Uh oh!

[onecta] Initial contribution #16730

Are you sure you want to change the base?

[onecta] Initial contribution #16730

Conversation

adr001db commented May 9, 2024

New Binding for Daikin using Onecta.

Description

Testing

Uh oh!

lsiepel commented May 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lsiepel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adr001db commented May 10, 2024

Uh oh!

lsiepel commented May 10, 2024

Uh oh!

adr001db commented May 10, 2024

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

lsiepel commented Jul 27, 2025

Uh oh!

adr001db commented Jul 27, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

jlaur commented Aug 23, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

adr001db commented Oct 11, 2025

Uh oh!

lsiepel commented Oct 11, 2025

Uh oh!

adr001db commented Oct 13, 2025

Uh oh!

lsiepel commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lsiepel commented Oct 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

lsiepel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lsiepel Oct 23, 2025

Choose a reason for hiding this comment

lsiepel commented May 9, 2024 •

edited

Loading

lsiepel commented Oct 20, 2025 •

edited

Loading