- 
                Notifications
    You must be signed in to change notification settings 
- Fork 197
include flagTags in postEvaluation and postEvaluationBatch #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8370f42    to
    b7117af      
    Compare
  
    | 
 Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   81.19%   76.50%   -4.69%     
==========================================
  Files          28       30       +2     
  Lines        2271     2418     +147     
==========================================
+ Hits         1844     1850       +6     
- Misses        337      478     +141     
  Partials       90       90              ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
b7117af    to
    75ccfc9      
    Compare
  
    637027c    to
    9ea1aca      
    Compare
  
    9ea1aca    to
    a01414f      
    Compare
  
    | @nothing0012 hello, can you please take a look? | 
        
          
                pkg/handler/eval_test.go
              
                Outdated
          
        
      | FlagTags: []string{"tag1", "tag2"}, | ||
| }, | ||
| }) | ||
| assert.NotNil(t, resp) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test kind of wrong, the intention I think it's to test if flagTags being included in the response, however, the test was just using tags as evaluation context input.
I think you could remove this line and assert that the tags were there in the resp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, thank you for the review
I've added correct assertions
473d3b1
| @zhouzhuojie @nothing0012 hello, can you please take a look once again? | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation and Context
We require the
flagTagsfield that includes all tags related to a particular flag in the response for our internal logic.How Has This Been Tested?
step_11_test_tag_batch_evaluationto ensure batch evaluations return:flagTagsfield presencestep_12_test_tag_operator_batch_evaluationto ensure:flagTagsfield presenceTypes of changes
Checklist: