Skip to content

feat(openfga): remove almost all DSL/JSON tabs with 1 exception #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(openfga): remove almost all DSL/JSON tabs with 1 exception #1031

wants to merge 1 commit into from

Conversation

ttrzeng
Copy link
Contributor

@ttrzeng ttrzeng commented May 14, 2025 •
edited
Loading

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ttrzeng ttrzeng requested a review from rhamzeh May 14, 2025 15:12
@ttrzeng ttrzeng requested review from a team as code owners May 14, 2025 15:12
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 14, 2025 •
edited
Loading

CLA Missing ID CLA Not Signed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2025 •
edited
Loading

PR Preview Action v1.6.1

🚀 View preview at
https://openfga.github.io/openfga.dev/pr-preview/pr-1031/

Built to branch gh-pages at 2025-05-28 21:32 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@cikasfm
Copy link

cikasfm commented May 14, 2025

@ttrzeng can you pls add before & after screenshots?

rhamzeh
rhamzeh requested changes May 14, 2025
View reviewed changes
@ttrzeng ttrzeng requested a review from rhamzeh May 14, 2025 18:11
@ttrzeng
Copy link
Contributor Author

ttrzeng commented May 14, 2025

@ttrzeng can you pls add before & after screenshots?

Before:
Screenshot 2025-05-14 at 2 22 21 PM

After:
Screenshot 2025-05-14 at 2 21 57 PM

@aaguiarz
Copy link
Member

Should we also decrease the margin on the top of the DSL text? cc @dongniwang

@ttrzeng
Copy link
Contributor Author

ttrzeng commented May 14, 2025

Should we also decrease the margin on the top of the DSL text? cc @dongniwang

FYI: what it will look like with less margin top:
Screenshot 2025-05-14 at 3 27 17 PM

@dongniwang
Copy link

Thanks @aaguiarz for flagging it. I did a little bit more investigation, it seems like the margin or extra padding is not a consistent thing across all pages. Some of the code blocks have the extra padding. See the configuration page for example.
image
I'd suggest @ttrzeng to keep this PR to focus on removing the tab and have a separate effort to look into why we have extra padding on some of them.
cc @dyeam0

@ttrzeng ttrzeng requested a review from pdillon May 16, 2025 16:25
@ttrzeng
feat(openfga): remove almost all DSL/JSON tabs with 1 exception
005bfc7 
verification test

verification test

verification test

remove redundancy

chore: add example for modular models (#1030)

remove unused variable

add syntaxToShow variable

chore: update docs with PG 17 support (#1024)

Co-authored-by: José Padilla <jpadilla@webapplicate.com>

ci: replace deprecated link check action (#1034)

comment fix

fix(docs): remove batchcheck endpoint support to js/python sdk note (#1035)
@ttrzeng ttrzeng closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh Awaiting requested review from rhamzeh

@pdillon pdillon Awaiting requested review from pdillon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ttrzeng @cikasfm @aaguiarz @dongniwang @rhamzeh