Skip to content

chore: cleanup tests, remove unused method, move urlEncode method #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

jimmyjames
Copy link
Contributor

Sync changes from generator to SDK for test cleanup and removal of unused method.

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jimmyjames jimmyjames requested a review from a team as a code owner May 6, 2025 16:51
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.42%. Comparing base (1af5cc1) to head (68b531a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #165   +/-   ##
=========================================
  Coverage     33.42%   33.42%           
- Complexity      991      994    +3     
=========================================
  Files           182      182           
  Lines          6902     6878   -24     
  Branches        771      772    +1     
=========================================
- Hits           2307     2299    -8     
+ Misses         4488     4476   -12     
+ Partials        107      103    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jimmyjames jimmyjames added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit 73648ba May 6, 2025
21 checks passed
@jimmyjames jimmyjames deleted the chore/tests-cleanup branch May 6, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants