-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix: refactor index_together to indexes for Django 5.2 support (V) model: StudentModuleHistoryExtended #36722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
fc0daaf
to
8f8b51d
Compare
331a433
to
a80523b
Compare
@dwong2708 thanks for the PR. I'll test this change on edX sandbox today and will schedule to merge this at the beginning of next week. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
To add Django 5.2 support as part of openedx/public-engineering#339, the index_together attribute in the StudentModuleHistoryExtended model was refactored to use indexes, based on the findings in openedx/public-engineering#343.
Testing instructions
Run this test:
pytest lms lms/djangoapps/coursewarehistoryextended/tests.py