Skip to content

fix: refactor index_together to indexes for Django 5.2 support (V) model: StudentModuleHistoryExtended #36722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

dwong2708
Copy link
Contributor

@dwong2708 dwong2708 commented May 14, 2025

Description

To add Django 5.2 support as part of openedx/public-engineering#339, the index_together attribute in the StudentModuleHistoryExtended model was refactored to use indexes, based on the findings in openedx/public-engineering#343.

Testing instructions

Run this test:

pytest lms lms/djangoapps/coursewarehistoryextended/tests.py

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 14, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented May 14, 2025

Thanks for the pull request, @dwong2708!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions May 14, 2025
@dwong2708 dwong2708 force-pushed the dw/index-together branch from fc0daaf to 8f8b51d Compare May 15, 2025 03:31
@dwong2708 dwong2708 changed the title fix: refactor index_together to indexes for Django 5.2 support fix: refactor index_together to indexes for Django 5.2 support (V) model: StudentModuleHistoryExtended May 15, 2025
@UsamaSadiq UsamaSadiq marked this pull request as ready for review May 15, 2025 05:58
@dwong2708 dwong2708 force-pushed the dw/index-together branch from 331a433 to a80523b Compare May 15, 2025 14:52
@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label May 15, 2025
@mphilbrick211 mphilbrick211 requested a review from feanil May 15, 2025 18:26
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions May 15, 2025
@UsamaSadiq
Copy link
Member

@dwong2708 thanks for the PR. I'll test this change on edX sandbox today and will schedule to merge this at the beginning of next week.

@feanil feanil merged commit 6232cd2 into openedx:master May 16, 2025
49 of 50 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions May 16, 2025
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants