This repository was archived by the owner on Aug 1, 2024. It is now read-only.
fix: remove escapes from demo_hash_password #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving the escapes in results in `CommandError: The password hash provided for user honor is invalid.` when trying to provision for the first time.
dianakhuang
approved these changes
Feb 17, 2023
timmc-edx
approved these changes
Feb 17, 2023
timmc-edx
reviewed
Feb 17, 2023
| @@ -57,9 +57,9 @@ for user in honor audit verified staff ; do | |||
| email="$user@example.com" | |||
| # Set staff flag for staff user | |||
| if [[ $user == "staff" ]] ; then | |||
| docker-compose exec -T lms bash -e -c "source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker --service-variant lms manage_user $user $email --initial-password-hash \'$demo_hashed_password\' --staff" | |||
| docker-compose exec -T lms bash -e -c "source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker --service-variant lms manage_user $user $email --initial-password-hash '$demo_hashed_password' --staff" | |||
There was a problem hiding this comment.
There are a bunch of script injection possibilities here (before and after, and unrelated). If we wanted to be safe, we could use printf with %q -- but it's probably not worth fixing in this context.
rgraber
deleted the
rsgraber/20230217-fix-provisioning-escaped-quotes
branch
nsprenkle
pushed a commit
that referenced
this pull request
Nov 21, 2023
Leaving the escapes in results in `CommandError: The password hash provided for user honor is invalid.` when trying to provision for the first time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving the escapes in results in
CommandError: The password hash provided for user honor is invalid.when trying to provision for the first time. See #997.I've completed each of the following or determined they are not applicable: