Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_accuracy_histogramintoshared.py#219The root problem is that details are duplicated between the templates and
db_helper.py. The original thought was that db_helper code could be moved into shared, but that by itself wouldn't fix the problem: the templates are still necessary. Putting everything in shared would result in less readable, less idiomatic generated code.The course proposed here is to
execthe templated code, and in some sense there is less duplication now... but just looking at the diff, it's hard to argue that this is actually simpler.For the reviewer: Is it better to stick with the status quo, and tolerate some duplication of code, and close this PR without merging, and close the linked issue... or add complexity with
exec, but have the polars expression in only one place? I'm on the fence.