-
Notifications
You must be signed in to change notification settings - Fork 5.8k
also link to CUDA::cufft_static in case of BUILD_SHARED_LIBS=OFF #3753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d156cfb
to
dceaf65
Compare
In any case someone uses older cmake versions: otherwise static linking does not work even with that fix. https://cmake.org/cmake/help/latest/module/FindCUDAToolkit.html#cuda-toolkit-cufft |
Should work with the latest changes as well. If the proper versions of cuda or cmake aren't met, it will fall back to dynamic libraries as was the behaviour previously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@cudawarped I'm new to the OpenCV workflow, is there anything missing starting a build on the CI? |
No. One of the core maintainers needs to have time to check this is sensible before kicking off the CI. As this is the contrib repo this in not as high a priority. |
@gregorburger Thanks a lot for the contribution! Could you push some change to the pr. Github Actions stuck and cannot be re-triggered. |
@gregorburger Please rebase the PR to current 4.x. |
In case BUILD_SHARED_LIBS is disabled, the cufft library is still linked to the dynamic version, whereas all other cuda libraries are linked to the static versions by appending CUDA_LIB_EXT. This PR makes cufft handles the same way as all other cuda libraries.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.