Skip to content

fix not merging when there are only two segs on one line #3719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Roger8
Copy link
Contributor

@Roger8 Roger8 commented Apr 11, 2024

Fixes #3715

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

This bug can be recurrent when there are only two segments on one line , if do_merge is set to be true.
The while loop will not enter in , then output has still two segments but not one merged one segment.

@Roger8
Copy link
Contributor Author

Roger8 commented Apr 11, 2024

fix #3719

@asmorkalov asmorkalov self-assigned this Apr 16, 2024
@asmorkalov asmorkalov merged commit 0658ab2 into opencv:4.x Apr 16, 2024
10 checks passed
@asmorkalov asmorkalov mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fast_line_detector will not merge segments while there are only two segs on one line
2 participants