Skip to content

further work on Ptcloud module #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

further work on Ptcloud module #2957

wants to merge 14 commits into from

Conversation

berak
Copy link
Contributor

@berak berak commented May 25, 2021

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

trying to take over, where #2584 left it.

added sprt stopping, preemptive segmentation, python bindings and tests

@berak berak force-pushed the ptcloud branch 6 times, most recently from f11a111 to 5874cfd Compare May 27, 2021 09:55
@berak
Copy link
Contributor Author

berak commented May 28, 2021

notes / todo / rfc

RTSP stopping is very useful here, and the USAC implementation from calib3d works nice.
however, i could not use the interfaces (needed to copy the code) because:

  • they're neither public (header is in calib3d src) nor are they exported (win dll) [minor]
  • they don't let me collect inlier indices (needed for local optimization later) [major]
  • the rtsp verifier run its own per-point loop, and neither collects inliers, nor errors (for ransac or msac), also we cannot use a index mask for already segmented points here

i finally mimicked the Error interface from USAC, a distance function per point. sadly this is hard to low-level optimize (simd,parallel,..), like this is done in pcl.

some stats (timing, inlier counts) in the interface would be nice, too

@berak
Copy link
Contributor Author

berak commented Dec 3, 2021

superseeded by opencv/opencv#21168
(which has much better USAC integration)

@berak berak closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants