Skip to content

Update submap.cpp for loop closure detection in 3d #20608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

zihaomu
Copy link
Member

@zihaomu zihaomu commented Aug 26, 2021

Related to PR3002 opencv/opencv_contirb.

The purpose is to add an edge-adding function of Loop Closure Detection detection, which is called when a loop was detected.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@zihaomu zihaomu changed the title Add submap for loop closure detection in 3d Update submap.cpp for loop closure detection in 3d Aug 26, 2021
@savuor savuor added the GSoC label Aug 26, 2021
Copy link
Contributor

@savuor savuor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes allows loop closure code to add loop closure edges to pose graph
Looks OK to me

@fengyuentau
Copy link
Member

jenkins cn please retry a build

@opencv-pushbot opencv-pushbot merged commit 14dedda into opencv:next Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants