Improve error readability for missing NWP data in PVNet model #69
Conversation
| normed_preds = [] | ||
| with torch.no_grad(): | ||
|
|
||
| # note this only running ones site |
There was a problem hiding this comment.
could you add these comment back in please
| log.exception("Failed to prepare data sources or load model.") | ||
| log.exception(f"Error: {e}") | ||
|
|
||
| def _get_config(self): |
There was a problem hiding this comment.
could you move these back to the same position there were. Otherwise its very hard to tell what has changed?
|
Hi, |
| dest_nwp_path=nwp_mo_global_path, | ||
| source="mo_global", | ||
| ), | ||
| try: |
There was a problem hiding this comment.
Soryr this wont do it. You need to actually look at the configuration and see if that data is available in the NWP data / timestamps
|
@peterdudfield I hv changed tho If possible, could you please explain in a bit more detail what else needs to be changed or checked? |
|
So as we load the NWP in, we can look at the time variable and see how far in the future the data goes. Then in configruation, we need to make sure there is enough data. Look in config --> NWP --> interval_end_minutes |
|
Note #67 is not marked at good-first-isse or contributors-welcome, so it maybe be easier for an internal OCF person to do it |
|
Sorry about that—my mistake. Thank you for your time and guidance! |
2 participants
Fixes #67
This PR improves error readability for the PVNet model when Numerical Weather Prediction (NWP) data is missing or invalid.
Instead of showing confusing traceback errors like:
ValueError: Did not find any periods ...
This PR adds user-friendly error messages:
Could not run the forecast because there wasn’t enough NWP data. Please check your NWP input files and time range.
How tested
Notes