Skip to content

Conversation

Averagenormaljoe
Copy link

Pull Request

Description

Changed the CLI command in 'site_forecast_app/app.py' for the app function to use the typer library instead of click. Additionally, changed the 'run_click_script' to 'run_typer_script' in 'tests/_utils.py' and replaced the CLI runner for click with typer.

This pull request is related to the issue #15.

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • [*] My code follows OCF's coding style guidelines
  • [*] I have performed a self-review of my own code
  • [*] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • [*] I have checked my code and corrected any misspellings

@peterdudfield
Copy link
Contributor

Can you fix lint, then I will review

@Averagenormaljoe
Copy link
Author

I will fix the lint.

@Averagenormaljoe
Copy link
Author

Should this pull request be removed as someone else is now working on the issue? @peterdudfield

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants