Decouple graph generation from model running #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbieker
added
documentation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Still need to add mapping from input grid to icosphere, and back
…raph-making # Conflicts: # graph_weather/models/graphs/ico.py
for more information, see https://pre-commit.ci
…raph-making # Conflicts: # graph_weather/models/graphs/ico.py
for more information, see https://pre-commit.ci
Still have an issue with the edges being redundant
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Keeping the grid2mesh, mesh, and mesh2grid separate allows for reducing the size of the graphs that have to stay in memory when running through the model.
…raph-making # Conflicts: # graph_weather/models/graphs/ico.py # graph_weather/models/graphs/utils.py
for more information, see https://pre-commit.ci
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR adds the ability to generate icosahedral graphs, like used in GraphCast, rather than the hexagonal graphs from
h3. This also decouples the models from the explicit graph, and allows the same model to be used with different graphs.This also adds some more support for GraphCast-type model, and takes inspiration from the Nvidia
moduluscode and the public DeepMind code.This PR also updates dependencies to the latest versions.
Fixes #
How Has This Been Tested?
Unit tests
Checklist: