fix: Update h3 API calls for v4.x compatibility #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbieker
requested changes
Oct 15, 2025
for more information, see https://pre-commit.ci
glitch401
force-pushed
the
fix/h3-compatibility
branch
from
d0ec4e8 to
b05ece7
Compare
|
updated pixi :D |
glitch401
commented
Oct 15, 2025
| pytest = "*" | ||
| pytest-xdist = "*" | ||
| h3 = "==3.7.7" | ||
| h3 = "==4.3.1" |
There was a problem hiding this comment.
@jacobbieker this should do for pixi, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR updates the codebase to be compatible with version 4.x of the
h3-pylibrary.The
h3-pylibrary introduced breaking API changes in its v4 release, renaming several core functions (e.g.,uncompact->uncompact_cells,geo_to_h3->latlng_to_cell,k_ring->grid_disk). The existing code was using the old, deprecated function names, which causesAttributeErrorexceptions for any user with an up-to-dateh3installation.This commit updates all calls to the
h3library ingraph_weather/models/layers/encoder.pyandgraph_weather/models/layers/assimilator_decoder.pyto use the new, correct function names, resolving the dependency conflict.Fixes #
How Has This Been Tested?
This is a direct API update to fix a dependency incompatibility. The changes were validated by confirming that the code now initializes and runs without the
AttributeErrorexceptions that were previously occurring. The project's existing CI test suite has provided the final validation for correctness.If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: