Skip to content

Conversation

FilippoContessa
Copy link

No description provided.

Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Sorry I missed this earlier, but have a few suggested changes. If you could also add a unit test that would be great! Just loading from a dummy Zarr store or something.

FilippoContessa and others added 3 commits January 21, 2025 11:23
Now shifting to 366 because of leap years

Co-authored-by: Jacob Prince-Bieker <jacob@bieker.tech>
Added a normalization feature
@FilippoContessa
Copy link
Author

Ok, i've tried to implement the normalization feature and shifted to 366 days, now i'll provide a unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants