Skip to content

Compatibility with ggplot2 4.0.0 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Compatibility with ggplot2 4.0.0 #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45f5385
don't use default aes
teunbrand Jan 30, 2025
20766cc
get margin the proper way
teunbrand Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions inTextSummaryTable/R/subjectProfileSummaryPlot.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,10 @@ subjectProfileSummaryPlot <- function(data,
yAxisExpand = c(0.05, 0.05),
yLimExpand = NULL,
xAxisLabs = NULL,
sizePoint = GeomPoint$default_aes$size,
sizeLine = GeomLine$default_aes$size,
sizeLabel = GeomText$default_aes$size,
widthErrorBar = GeomErrorbar$default_aes$width,
Comment on lines -154 to -157
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are now mostly dynamic instead of static values, so you can't read them out directly anymore. The easiest thing is to just put fixed values here.

sizePoint = 1.5,
sizeLine = 0.5,
sizeLabel = 3.87,
widthErrorBar = 0.9,
tableText = NULL, tableTextFontface = 1,
tableHeight = 0.1,
tableYAxisLabs = !is.null(colorVar),
Expand Down Expand Up @@ -659,7 +659,7 @@ subjectProfileSummaryPlot <- function(data,
ggTable <- ggTable + fctScaleX

# remove legend and title x-axis for base plot (will be included in table plot)
plotMargin <- themeFct()$plot.margin
plotMargin <- calc_element("plot.margin", themeFct())
plotMargin[3] <- tablePlotMargin # set bottom margin
gg <- gg + theme(
legend.position = "none",
Expand Down