forked from ImSwitch/ImSwitch
-
Notifications
You must be signed in to change notification settings - Fork 17
Complete ESP32InfoScreen controller implementation with enhanced hardware control and rate-limited communication #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
7
commits into
master
Choose a base branch
from
copilot/fix-134
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: beniroquai <4345528+beniroquai@users.noreply.github.com>
Co-authored-by: beniroquai <4345528+beniroquai@users.noreply.github.com>
Copilot finished work on behalf of
beniroquai
August 17, 2025 06:36
Deleted ESP32InfoScreenWidget.py and its import from widgets/__init__.py. Refactored ESP32InfoScreenController to remove direct widget interactions and UI signal connections, focusing on controller logic only. This change decouples the controller from the UI, likely in preparation for headless operation or a new UI approach.
@copilot can you fix the TODOs in the code please? |
…, enhanced motor control, laser management, and signal handling Co-authored-by: beniroquai <4345528+beniroquai@users.noreply.github.com>
Fixed all TODOs in the ESP32InfoScreen controller (commit b8bf90f). Key improvements:
The controller now provides robust bidirectional communication with proper rate limiting and comprehensive hardware integration. |
Copilot finished work on behalf of
beniroquai
August 18, 2025 05:08
Introduces setSingleShot() to the Timer abstract base and implements it in the noqt backend. This allows timers to be configured to fire only once per start or to repeat, improving flexibility for timer usage.
Added bidirectional mapping between lasers and ESP32 PWM channels, improved handling of laser value updates, and implemented support for absolute position commands from ESP32. Introduced new signals and API methods for reconnecting and checking ESP32 connection status. Removed SQUIDLaserManager and SQUIDLedManager files, and made related updates to controllers and serial communication logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a comprehensive implementation of the ESP32InfoScreen controller, transforming it from a skeleton with TODO placeholders into a fully functional bidirectional communication system between ImSwitch and ESP32 devices with attached displays.
Key Features Implemented
🔄 Rate-Limited Communication System
Implemented a sophisticated rate limiting mechanism to prevent ESP32 serial communication issues:
🎯 Enhanced Motor Control
Complete motor control implementation supporting multiple movement modes:
moveForever
for joystick interactionspositioner.stop()
⚡ Smart Laser Management
Automatic laser state management with PWM control:
🔒 Recursion-Safe Signal Handling
Implemented robust signal management to prevent infinite loops:
📡 Complete Bidirectional Integration
ESP32 → ImSwitch Control:
ImSwitch → ESP32 Status Updates:
🛡️ Enhanced Error Handling & Safety
finalize()
method with timer managementHardware Integration
The controller seamlessly integrates with existing ImSwitch managers:
ESP32StageManager
for motor controlESP32LEDMatrixManager
for LED matrix controlESP32LEDLaserManager
for laser controlCode Quality Improvements
Usage
Simply add
"ESP32InfoScreen"
to your setup'savailableWidgets
list. The controller automatically detects and connects to ESP32 devices, providing immediate bidirectional control with robust communication management.Fixes #134.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.