feat : Activate migrated to CMP #2388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revanthkumarJ
changed the title
niyajali
requested changes
May 27, 2025
| ) | ||
| } | ||
| // | ||
| //private class ActivateUiStateProvider : PreviewParameterProvider<ActivateUiState> { |
There was a problem hiding this comment.
Enable Compose Multiplatform Preview, Uncomment these lines
| @@ -40,15 +50,15 @@ class ActivateViewModel( | |||
| viewModelScope.launch(Dispatchers.IO) { | |||
| @@ -40,15 +50,15 @@ class ActivateViewModel( | |||
| viewModelScope.launch(Dispatchers.IO) { | |||
| activateClientUseCase(clientId, clientPayload).collect { result -> | |||
| when (result) { | |||
| is Resource.Error<*> -> | |||
| is DataState.Error<*> -> | |||
There was a problem hiding this comment.
Why these DataState type contains <*> fix it
| @@ -74,15 +84,15 @@ class ActivateViewModel( | |||
| viewModelScope.launch(Dispatchers.IO) { | |||
itsPronay
reviewed
May 27, 2025
Comment on lines
120
to
123
| LaunchedEffect(true){ | ||
| snackbarHostState.showSnackbar(getString( state.message)) | ||
| } | ||
| onBackPressed() |
There was a problem hiding this comment.
Snackbar might not show by the time onBackPressed() is called, use alertdialog whenever possible.
Also if I am not wrong it only runs during the initial composition.
There was a problem hiding this comment.
changed to MifosAlertDialog
itsPronay
reviewed
May 27, 2025
Comment on lines
209
to
212
| fun formatDate(millis: Long): String { | ||
| val dateTime = Instant.fromEpochMilliseconds(millis).toLocalDateTime(TimeZone.currentSystemDefault()) | ||
| return "${dateTime.dayOfMonth} ${dateTime.month.name.lowercase().replaceFirstChar { it.uppercase() }} ${dateTime.year}" | ||
| } |
There was a problem hiding this comment.
can we put this in common? since it will be used in like 5/7 screen
There was a problem hiding this comment.
ok i will move it to common
itsPronay
reviewed
May 27, 2025
| @@ -57,15 +67,15 @@ class ActivateViewModel( | |||
| viewModelScope.launch(Dispatchers.IO) { | |||
There was a problem hiding this comment.
remove dispatchers.IO , check line 84 as well
niyajali
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-413