feat: search migrate to cmp #2386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kapmaurya is it done? |
|
@kapmaurya run the application and upload screenshots |
revanthkumarJ
suggested changes
May 27, 2025
There was a problem hiding this comment.
@kapmaurya do the mentioned changes and upload screenshots.
Double check
- remove comments
- change fontSize to MaterialTheme.typography
- use MifosIcons
|
|
||
| AlertDialog( | ||
| modifier = modifier.widthIn(max = configuration.screenWidthDp.dp - 80.dp), | ||
| modifier = modifier.widthIn(max = dialogMaxWidth), |
There was a problem hiding this comment.
I think we have MifosAlertDialog see it and use it
There was a problem hiding this comment.
name of that composable is MifosDialogBox
feature/search/src/commonMain/kotlin/com/mifos/feature/search/components/SearchBox.kt
Show resolved
Hide resolved
feature/search/src/commonMain/kotlin/com/mifos/feature/search/components/SearchBox.kt
Outdated
Show resolved
Hide resolved
feature/search/src/commonMain/kotlin/com/mifos/feature/search/components/SearchScreenResult.kt
Outdated
Show resolved
Hide resolved
|
@kapmaurya @revanthkumarJ is it done |
|
@kapmaurya if it is done upload screenshots , if you are facing any issue mention those screenshots and issue in android-client slack channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - [Jira-#Issue_Number](https://mifosforge.jira.com/browse/MIFOSAC-428)
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.