Skip to content

Integrate Fastlane and update CI workflows #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 29, 2025

Conversation

itsPronay
Copy link
Contributor

Fixes - Jira-#Issue_Number

Didn't create a Jira ticket, click here to create new.

Please Add Screenshots If there are any UI changes.

Before After

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@itsPronay itsPronay force-pushed the workflow-fixing branch 2 times, most recently from 7c514cc to 9cf0ca3 Compare May 25, 2025 14:59
@therajanmaurya therajanmaurya changed the title draft Fix PR Check KMP Workflow May 27, 2025
@niyajali
Copy link
Collaborator

@HekmatullahAmin can you set up the workflows on this project on kmp branch

@itsPronay itsPronay marked this pull request as draft May 27, 2025 15:05
@HekmatullahAmin
Copy link
Contributor

@niyajali Ok i will fix just one thing you mentioned use pr-check-android.yml it only check the Static Analysis Check and build the android app should I proceed using that?

@HekmatullahAmin
Copy link
Contributor

@itsPronay, Niyaj suggested to use pr-check-android.yaml. So in you kmp-pr-check.yml in line 85 use this:

  • openMF/mifos-x-actionhub/.github/workflows/pr-check-android.yaml@v1.0.1
    and inside the with: just keep:
  • android_package_name: 'cmp-android' # <-- Change Your Android Package Name
    and remove the rest and also remove secrets: inherit from line 86

it will solve the issue

@itsPronay
Copy link
Contributor Author

itsPronay commented May 27, 2025

@HekmatullahAmin I have implemented your suggestions, can you take a look

@itsPronay itsPronay marked this pull request as ready for review May 27, 2025 16:30
@HekmatullahAmin
Copy link
Contributor

@itsPronay i will fix other workflows in this PR. Just a question why there is no fastlane package in the kmp-impl branch?

@HekmatullahAmin
Copy link
Contributor

HekmatullahAmin commented May 28, 2025

@itsPronay change your PR title to Integrate Fastlane and update CI workflows
And also I don't know why ActivateScreen.kt and ActivateViewModel.kt is modified look into it and if necessary revert it back

@itsPronay itsPronay changed the title Fix PR Check KMP Workflow Integrate Fastlane and update CI workflows May 28, 2025
@itsPronay
Copy link
Contributor Author

@HekmatullahAmin It was modified to pass static analysis check since it was failing

@niyajali niyajali merged commit 43c5c6d into openMF:kmp-impl May 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants