Work-report distribution & Work-report request #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 86.82% 86.84% +0.02%
==========================================
Files 348 350 +2
Lines 29480 29661 +181
==========================================
+ Hits 25595 25760 +165
- Misses 3885 3901 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xlc
approved these changes
Apr 23, 2025
| func add(block: BlockRef) async throws | ||
| func add(state: StateRef) async throws | ||
| func setFinalizedHead(hash: Data32) async throws | ||
|
|
||
| /// throw BlockchainDataProviderError.noData if parent is not a head | ||
| func updateHead(hash: Data32, parent: Data32) async throws | ||
|
|
||
| /// remove header, block and state | ||
| /// remove header, block, workReport, state |
There was a problem hiding this comment.
best to have a remove(blockHash: Data32) and a remove(workReportHash: Data32) to ensure we don't mix different kinds of hashes
Comment on lines
+415
to
+417
| if case let .failure(error) = resp.result { | ||
| throw error // failed | ||
| } |
There was a problem hiding this comment.
Suggested change
| if case let .failure(error) = resp.result { | |
| throw error // failed | |
| } | |
| _ = try resp.result.get() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.