Feat(metadata): basic metadata api support #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Jul 29, 2024
xlc
reviewed
Jul 30, 2024
xcq-extension-fungibles/src/lib.rs
Outdated
| type AccountId: Decode; | ||
| type AssetId: Decode; | ||
| type Balance: Encode; | ||
| type AssetId: Encode + Decode; |
There was a problem hiding this comment.
Suggested change
| type AssetId: Encode + Decode; | |
| type AssetId: Codec; |
| // quote! {} | ||
| // }; | ||
| Ok(parse_quote!( | ||
| #[derive(Decode)] |
There was a problem hiding this comment.
need to use fully qualified name for Decode
xlc
reviewed
Jul 30, 2024
| __Phantom(core::marker::PhantomData<Impl>) | ||
| )); | ||
| Ok(parse_quote!( | ||
| #[derive(parity_scale_codec::Decode)] |
There was a problem hiding this comment.
will this work if parity_scale_codec was imported with a different name? maybe we need to do something like #xcq_extension::deps::parity_scale_codec::Decode
xlc
reviewed
Jul 31, 2024
| @@ -18,6 +18,7 @@ pub type XcqResult = Result<XcqResponse, XcqError>; | |||
| pub mod metadata; | |||
| pub mod metadata_ir; | |||
|
|
|||
| pub mod umbrella { | |||
| pub mod deps { | |||
There was a problem hiding this comment.
add #[doc(hidden)] for internal use only but public items
xlc
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.