-
Notifications
You must be signed in to change notification settings - Fork 207
feat: use sha for actions #1825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use sha for actions #1825
Conversation
I'm ok with SHA for |
I think dependabot is a great ally for this use case, but I'm ok to revert the change for GitHub-vended actions. Let me know! |
Actually, both approaches have their own pros and cons, but, yes, using SHA is the recommended approach by Github especially in terms of security. Also, pinning actions by SHA helps to have better OSSF score:
So, I am personally OK with these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does dependabot maintain the version in comments? I appreciate that and hope it does. The main thing that I don't like about SHAs is the version number is opaque.
Yes, dependabot will update the comments |
Yes, comments are updated too. So, merging this one too. |
Fixes #1769
The original issue mentioned that it should only apply to non github-vended actions but I think it's safer to apply it everywhere. For instance
actions/cache
has 100+ contributors, and not all of them are from the official GitHub org.The sha was already set for some github-vended actions in some workflows but it was inconsistent, this PR adds shas for 100% of actions