make debug exporter available for custom builds #1551
Conversation
|
Just sharing a thought: If you decide to move this out of experimental eventually, we could make use of this for both the default and custom build, by including the default components without any additional build tag, i.e.: Component included in default build (no tags provided) - available either if Component only available for custom builds - available only if explicitly included: Also, if (emphasis on if) you decide to move this out of experimental, a CI build with |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
There was a problem hiding this comment.
The convention in collector-contrib is to simply use...
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
Although the convention differs in this repo, I think it's innocuous migration that would be worthwhile. Since the convention here differs I'm not suggesting this PR has to be the place where we would migrate. And I'm certainly open to other reasoning.
The benefit in this case would be almost a 50% reduction in the line scan requirement for reviewers and other readers. To my brain that matters. It's also nicer to see that someone has requested a review on 50% fewer lines, when 1/2 of that is skimming over license detail.
To be clear, I'm approving as is in keeping with current practice here. And defer to consensus on whether and when we would migrate.
There was a problem hiding this comment.
I support switching to the shorter format. How do we standardize that here?
|
Should we remove the custom build support for the logging exporter? |
I think it should stay as long as it stays in default too |
This PR makes the debug exporter available for customized builds (#1427).
The debug exporter was added to default in #1520