Skip to content

Stop using ConfigProvider #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Stop using ConfigProvider #1379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions collector/internal/collector/collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ import (
// Collector runs a single otelcol as a go routine within the
// same process as the executor.
type Collector struct {
factories otelcol.Factories
configProvider otelcol.ConfigProvider
svc *otelcol.Collector
appDone chan struct{}
stopped bool
logger *zap.Logger
version string
factories otelcol.Factories
cfgProSet otelcol.ConfigProviderSettings
svc *otelcol.Collector
appDone chan struct{}
stopped bool
logger *zap.Logger
version string
}

func getConfig(logger *zap.Logger) string {
Expand All @@ -69,17 +69,12 @@ func NewCollector(logger *zap.Logger, factories otelcol.Factories, version strin
},
},
}
cfgProvider, err := otelcol.NewConfigProvider(cfgSet)

if err != nil {
l.Fatal("error creating config provider", zap.Error(err))
}

col := &Collector{
factories: factories,
configProvider: cfgProvider,
logger: logger,
version: version,
factories: factories,
cfgProSet: cfgSet,
logger: logger,
version: version,
}
return col
}
Expand All @@ -91,7 +86,7 @@ func (c *Collector) Start(ctx context.Context) error {
Description: "Lambda Collector",
Version: c.version,
},
ConfigProvider: c.configProvider,
ConfigProviderSettings: c.cfgProSet,
Factories: func() (otelcol.Factories, error) {
return c.factories, nil
},
Expand Down
Loading