Skip to content

deps: update to sinon@18.0.1 #5742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jun 4, 2025

Which problem is this PR solving?

sinon is quite outdated and it's somewhat difficult to update due to some breaking changes, mostly around fake timers.
After attempting to update to latest multiple times, I've opted to increment major versions one-by-one to preserve my sanity.

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (3578f68) to head (e97d996).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5742   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files         310      310           
  Lines        8013     8013           
  Branches     1620     1620           
=======================================
  Hits         7616     7616           
  Misses        397      397           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc marked this pull request as ready for review June 4, 2025 15:32
@pichlermarc pichlermarc requested a review from a team as a code owner June 4, 2025 15:32
@pichlermarc pichlermarc changed the title deps: update to sinon@16.1.6 deps: update to sinon@17.0.2 Jun 5, 2025
@pichlermarc pichlermarc changed the title deps: update to sinon@17.0.2 deps: update to sinon@18.0.1 Jun 5, 2025
@pichlermarc
Copy link
Member Author

I think 18.01 is as far as I'm going to get for this PR. I'll pick up work on the 19 and 20 in other PRs.

@pichlermarc pichlermarc added this pull request to the merge queue Jun 6, 2025
Merged via the queue into open-telemetry:main with commit a4e9645 Jun 6, 2025
34 of 35 checks passed
@pichlermarc pichlermarc deleted the chore/update-sinon branch June 6, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants